From 82bf41f3abce4a13e7c6ad1606eb708f371de87f Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Fri, 3 Apr 2020 17:03:38 +0200 Subject: avformat: Replace ffurl_close() by ffurl_closep() where appropriate It avoids leaving dangling pointers behind in memory. Also remove redundant checks for whether the URLContext to be closed is already NULL. Reviewed-by: Anton Khirnov Signed-off-by: Andreas Rheinhardt --- libavformat/async.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'libavformat/async.c') diff --git a/libavformat/async.c b/libavformat/async.c index 4e295b5e10..a0bdfa2ee3 100644 --- a/libavformat/async.c +++ b/libavformat/async.c @@ -293,7 +293,7 @@ cond_wakeup_background_fail: cond_wakeup_main_fail: pthread_mutex_destroy(&c->mutex); mutex_fail: - ffurl_close(c->inner); + ffurl_closep(&c->inner); url_fail: ring_destroy(&c->ring); fifo_fail: @@ -317,7 +317,7 @@ static int async_close(URLContext *h) pthread_cond_destroy(&c->cond_wakeup_background); pthread_cond_destroy(&c->cond_wakeup_main); pthread_mutex_destroy(&c->mutex); - ffurl_close(c->inner); + ffurl_closep(&c->inner); ring_destroy(&c->ring); return 0; -- cgit v1.2.3