From 15b2c37d5e1155a96630eb5f8758fd849d6b2a2e Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Fri, 3 Feb 2017 19:37:18 +0100 Subject: avfilter/vf_deshake: Free out AVFrame on error Fixes memleak Fixes part of CID1197065 Signed-off-by: Michael Niedermayer --- libavfilter/vf_deshake.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'libavfilter') diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c index 4eae9885c6..64b48c6d02 100644 --- a/libavfilter/vf_deshake.c +++ b/libavfilter/vf_deshake.c @@ -450,7 +450,7 @@ static int filter_frame(AVFilterLink *link, AVFrame *in) if (CONFIG_OPENCL && deshake->opencl) { ret = ff_opencl_deshake_process_inout_buf(link->dst,in, out); if (ret < 0) - return ret; + goto fail; } if (deshake->cx < 0 || deshake->cy < 0 || deshake->cw < 0 || deshake->ch < 0) { @@ -536,13 +536,16 @@ static int filter_frame(AVFilterLink *link, AVFrame *in) av_frame_free(&deshake->ref); if (ret < 0) - return ret; + goto fail; // Store the current frame as the reference frame for calculating the // motion of the next frame deshake->ref = in; return ff_filter_frame(outlink, out); +fail: + av_frame_free(&out); + return ret; } static const AVFilterPad deshake_inputs[] = { -- cgit v1.2.3