From 0d3123666a42ed6c74d0a052342175261304b8ca Mon Sep 17 00:00:00 2001 From: Xi Wang Date: Wed, 14 Nov 2012 03:42:37 -0500 Subject: cdgraphics: fix incorrect vertical offset mask in cdg_scroll() The vertical offset mask 0x07 is suspicious. v_off = FFMIN(data[2] & 0x07, CDG_BORDER_HEIGHT - 1); Note that v_off is up to 11 (CDG_BORDER_HEIGHT - 1), the correct mask should be 0x0F. Signed-off-by: Xi Wang Signed-off-by: Anton Khirnov --- libavcodec/cdgraphics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libavcodec/cdgraphics.c') diff --git a/libavcodec/cdgraphics.c b/libavcodec/cdgraphics.c index 21de07effb..631c415124 100644 --- a/libavcodec/cdgraphics.c +++ b/libavcodec/cdgraphics.c @@ -218,7 +218,7 @@ static void cdg_scroll(CDGraphicsContext *cc, uint8_t *data, vscmd = (data[2] & 0x30) >> 4; h_off = FFMIN(data[1] & 0x07, CDG_BORDER_WIDTH - 1); - v_off = FFMIN(data[2] & 0x07, CDG_BORDER_HEIGHT - 1); + v_off = FFMIN(data[2] & 0x0F, CDG_BORDER_HEIGHT - 1); /// find the difference and save the offset for cdg_tile_block usage hinc = h_off - cc->hscroll; -- cgit v1.2.3