From 7ab37cae34b3845de7b689d167661bb4a5c2ab5b Mon Sep 17 00:00:00 2001 From: Ganesh Ajjanagadde Date: Wed, 6 Jan 2016 20:57:47 -0800 Subject: ffmpeg: check fclose return values In the spirit of commit a956840cbc. Simple method to reproduce: pass -vstats_file /dev/full to ffmpeg. All raw fclose usages in ffmpeg.c taken care of here. Reviewed-by: Michael Niedermayer Signed-off-by: Ganesh Ajjanagadde --- ffmpeg.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'ffmpeg.c') diff --git a/ffmpeg.c b/ffmpeg.c index 659bd7f3c1..86a0960242 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -554,8 +554,12 @@ static void ffmpeg_cleanup(int ret) av_freep(&input_streams[i]); } - if (vstats_file) - fclose(vstats_file); + if (vstats_file) { + if (fclose(vstats_file)) + av_log(NULL, AV_LOG_ERROR, + "Error closing vstats file, loss of information possible: %s\n", + av_err2str(AVERROR(errno))); + } av_freep(&vstats_filename); av_freep(&input_streams); @@ -4200,7 +4204,10 @@ static int transcode(void) ost = output_streams[i]; if (ost) { if (ost->logfile) { - fclose(ost->logfile); + if (fclose(ost->logfile)) + av_log(NULL, AV_LOG_ERROR, + "Error closing logfile, loss of information possible: %s\n", + av_err2str(AVERROR(errno))); ost->logfile = NULL; } av_freep(&ost->forced_kf_pts); -- cgit v1.2.3