From 00b62968d079e63bf22028f253ac297292436ebe Mon Sep 17 00:00:00 2001 From: Martin Storsjö Date: Wed, 28 Oct 2015 22:19:12 +0200 Subject: os_support: Don't try to return the service name as a string in getnameinfo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some systems may be lacking getservbyport; the previous ifdef wasn't quite enough since it still assumed that struct servent was defined, as pointed out by Clément Gregoire. Simply remove the possibility to return non-numeric services in getnameinfo; no caller of getnameinfo within libavformat currently try to use getnameinfo for retrieving the port number without NI_NUMERICSERV, and falling back on getservbyport may be non-threadsafe. Signed-off-by: Martin Storsjö --- configure | 2 -- 1 file changed, 2 deletions(-) (limited to 'configure') diff --git a/configure b/configure index d941d95027..cbd8c5aa52 100755 --- a/configure +++ b/configure @@ -1513,7 +1513,6 @@ SYSTEM_FUNCS=" GetProcessMemoryInfo GetProcessTimes getrusage - getservbyport GetSystemTimeAsFileTime gettimeofday gmtime_r @@ -4240,7 +4239,6 @@ fi if ! disabled network; then check_func getaddrinfo $network_extralibs - check_func getservbyport $network_extralibs check_func inet_aton $network_extralibs check_type netdb.h "struct addrinfo" -- cgit v1.2.3