From 2cdba8bfc43b818ca8037421c9a136fa89327c66 Mon Sep 17 00:00:00 2001 From: Diego Biurrun Date: Wed, 29 Oct 2008 06:48:59 +0000 Subject: Add 'make checkheaders' to developer guidelines and patch checklist. Originally committed as revision 15741 to svn://svn.ffmpeg.org/ffmpeg/trunk --- doc/general.texi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/general.texi b/doc/general.texi index 78372f6a0c..9a823d4d8c 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -951,6 +951,9 @@ should also be avoided if they don't make the code easier to understand. @item If you add a new file, give it a proper license header. Do not copy and paste it from a random place, use an existing file as template. +@item + If you add a new header or change an existing one, make sure it passes + @code{make checkheaders}. @end enumerate We think our rules are not too hard. If you have comments, contact us. @@ -1025,6 +1028,8 @@ do not attach several unrelated patches to the same mail. @enumerate @item Do the regression tests pass with the patch applied? +@item + Does @code{make checkheaders} pass with the patch applied? @item Is the patch a unified diff? @item -- cgit v1.2.3