summaryrefslogtreecommitdiff
path: root/libavfilter/af_dynaudnorm.c
Commit message (Collapse)AuthorAge
* avfilter/af_dynaudnorm: Store format in filter, remove query functionAndreas Rheinhardt2021-10-05
| | | | Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter: Replace query_formats callback with union of list and callbackAndreas Rheinhardt2021-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If one looks at the many query_formats callbacks in existence, one will immediately recognize that there is one type of default callback for video and a slightly different default callback for audio: It is "return ff_set_common_formats_from_list(ctx, pix_fmts);" for video with a filter-specific pix_fmts list. For audio, it is the same with a filter-specific sample_fmts list together with ff_set_common_all_samplerates() and ff_set_common_all_channel_counts(). This commit allows to remove the boilerplate query_formats callbacks by replacing said callback with a union consisting the old callback and pointers for pixel and sample format arrays. For the not uncommon case in which these lists only contain a single entry (besides the sentinel) enum AVPixelFormat and enum AVSampleFormat fields are also added to the union to store them directly in the AVFilter, thereby avoiding a relocation. The state of said union will be contained in a new, dedicated AVFilter field (the nb_inputs and nb_outputs fields have been shrunk to uint8_t in order to create a hole for this new field; this is no problem, as the maximum of all the nb_inputs is four; for nb_outputs it is only two). The state's default value coincides with the earlier default of query_formats being unset, namely that the filter accepts all formats (and also sample rates and channel counts/layouts for audio) provided that these properties agree coincide for all inputs and outputs. By using different union members for audio and video filters the type-unsafety of using the same functions for audio and video lists will furthermore be more confined to formats.c than before. When the new fields are used, they will also avoid allocations: Currently something nearly equivalent to ff_default_query_formats() is called after every successful call to a query_formats callback; yet in the common case that the newly allocated AVFilterFormats are not used at all (namely if there are no free links) these newly allocated AVFilterFormats are freed again without ever being used. Filters no longer using the callback will not exhibit this any more. Reviewed-by: Paul B Mahol <onemda@gmail.com> Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/af_dynaudnorm: add support for filtering non-writable framesPaul B Mahol2021-10-05
| | | | | Previously it would continue processing frame even if call to make frame writable failed.
* avfilter/af_dynaudnorm: fix possible clipping at start when alt-boundary ↵Paul B Mahol2021-10-05
| | | | mode is disabled
* avfilter/af_dynaudnorm: improve EOF timestamp precisionPaul B Mahol2021-09-12
|
* avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilterAndreas Rheinhardt2021-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Up until now, an AVFilter's lists of input and output AVFilterPads were terminated by a sentinel and the only way to get the length of these lists was by using avfilter_pad_count(). This has two drawbacks: first, sizeof(AVFilterPad) is not negligible (i.e. 64B on 64bit systems); second, getting the size involves a function call instead of just reading the data. This commit therefore changes this. The sentinels are removed and new private fields nb_inputs and nb_outputs are added to AVFilter that contain the number of elements of the respective AVFilterPad array. Given that AVFilter.(in|out)puts are the only arrays of zero-terminated AVFilterPads an API user has access to (AVFilterContext.(in|out)put_pads are not zero-terminated and they already have a size field) the argument to avfilter_pad_count() is always one of these lists, so it just has to find the filter the list belongs to and read said number. This is slower than before, but a replacement function that just reads the internal numbers that users are expected to switch to will be added soon; and furthermore, avfilter_pad_count() is probably never called in hot loops anyway. This saves about 49KiB from the binary; notice that these sentinels are not in .bss despite being zeroed: they are in .data.rel.ro due to the non-sentinels. Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/formats: Factor common function combinations outAndreas Rheinhardt2021-08-13
| | | | | | | | | | | Several combinations of functions happen quite often in query_format functions; e.g. ff_set_common_formats(ctx, ff_make_format_list(sample_fmts)) is very common. This commit therefore adds functions that are equivalent to commonly used function combinations in order to reduce code duplication. Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter: Constify all AVFiltersAndreas Rheinhardt2021-04-27
| | | | | | | This is possible now that the next-API is gone. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Signed-off-by: James Almer <jamrial@gmail.com>
* avfilter/af_dynaudnorm: make better check for available samplesPaul B Mahol2021-03-10
| | | | Also report more correct EOF timestamp.
* avfilter/af_dynaudnorm: use better limits for maximal amplificationPaul B Mahol2020-01-11
| | | | Fixes regression in smoothness of amplification.
* avfilter/af_dynaudnorm: add support for commandsPaul B Mahol2020-01-06
|
* avfilter/af_dynaudnorm: use already available pointerPaul B Mahol2020-01-05
| | | | Instead of dereferencing same thing again.
* avfilter/af_dynaudnorm: move channels variable setup firstPaul B Mahol2020-01-05
|
* avfilter/af_dynaudnorm: fix another clipping with custom peak valuePaul B Mahol2020-01-04
| | | | | This always happened at start with alternative boundary mode disabled. The clipping only occurred if starting samples where high enough.
* avfilter/af_dynaudnorm: implement threshold optionPaul B Mahol2020-01-04
|
* avfilter/af_dynaudnorm: do not clip audioPaul B Mahol2020-01-04
| | | | | | Clipping can happen when smoothed gain is higher than maximum allowed gain factor for current frame and peak value option is set to enough low value.
* avfilter/af_dynaudnorm: fix previous commitPaul B Mahol2020-01-02
| | | | We still need to analyze frame for amplification at EOF.
* avfilter/af_dynaudnorm: do not enqueue flush buffersPaul B Mahol2020-01-02
|
* avfilter/af_dynaudnorm: do not hang forever if only EOF is receivedPaul B Mahol2020-01-01
|
* avfilter/af_dynaudnorm: do not error out if even filter size was givenPaul B Mahol2020-01-01
| | | | Instead issue a warning and make filter size odd number.
* avfilter/af_dynaudnorm: add more descriptive aliases for optionsPaul B Mahol2019-07-24
|
* avfilter/af_dynaudnorm: add timeline supportPaul B Mahol2019-04-30
|
* avfilter/af_dynaudnorm: always update delay when flushingPaul B Mahol2019-04-30
|
* avfilter/af_dynaudnorm: switch to activatePaul B Mahol2019-04-29
|
* avfilter/dynaudnorm: increment input outside of the FFMIN macro so it ↵Andy2017-08-09
| | | | doesn't get double incremented
* avfilter: do not use AVFrame accessorMuhammad Faiz2017-04-23
| | | | | Reviewed-by: wm4 <nfxjfg@googlemail.com> Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
* lavfi/dynaudnorm: rename pow2 to pow_2Clément Bœsch2017-03-29
| | | | | | | | | | | This conflict with the DJGPP libc which includes a pow2 function¹ We cannot make DJGPP POSIX only (using -D_POSIX_SOURCE) to avoid this kind of symbols conflicts due to the lack of both posix_memalign and memalign (DJGPP non standard function) in that POSIX mode. We currently rely on memalign for aligned heap allocation. [1]: http://www.delorie.com/djgpp/doc/libc-2.02/libc_536.html
* avfilter/af_dynaudnorm: fix hang with too short inputPaul B Mahol2017-01-08
| | | | | | The only thing we can do at such point is return samples unchanged. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_dynaudnorm: use better check for infinite loopPaul B Mahol2016-08-07
| | | | Apparently due to rounding this happens.
* avfilter/af_dynaudnorm: improve pre-filling codeLoRd_MuldeR2016-08-02
| | | | | | | | In order to avoid possible clipping at the very beginning. Especially apparent when "alternative" boundary mode is used. Adopted from original commit by committer.
* avfilter/af_dynaudnorm: call uninit() from config_input()Paul B Mahol2016-01-19
| | | | | | Should help dynamic filtergraph reconfiguration. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_dynaudnorm: fix possible null pointer dereferencePaul B Mahol2016-01-14
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* lavfi/af_dynaudnorm: replace round by lrintGanesh Ajjanagadde2015-12-21
| | | | | | | lrint is at least as fast, uses a superior rounding mode, and avoids an implicit cast. Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
* avfilter/af_dynaudnorm: use av_malloc_array()Paul B Mahol2015-12-19
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_dynaudnorm: remove wasteful powGanesh Ajjanagadde2015-11-26
| | | | | | | | This removes wasteful pow(x, 2.0) that although not terribly important for speed, is still useless. Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
* avfilter/af_dynaudnorm: use M_PIGanesh Ajjanagadde2015-11-20
| | | | | | | | | | The ad-hoc pi constant has a ludicrous number of digits that offer no value whatsoever. M_PI is more consistent and readable across the codebase. Reviewed-by: Paul B Mahol <onemda@gmail.com> Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
* lavfi: remove FF_LINK_FLAG_REQUEST_LOOP.Nicolas George2015-09-20
| | | | It has no longer any effect.
* avfilter: use ff_all_channel_counts() instead of ff_all_channel_layouts()Paul B Mahol2015-09-12
| | | | | | Fixes playback of some files with ffplay. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/dynaudnorm: use AV_OPT_TYPE_BOOLClément Bœsch2015-09-08
|
* avfilter/af_dynaudnorm: Fix typo in assertMichael Niedermayer2015-09-03
| | | | | | | Fixes: CID1322303 Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avfilter/af_dynaudnorm: Use av_frame_get_channels()Michael Niedermayer2015-07-18
| | | | Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avfilter/af_dynaudnorm: Fix "ISO C90 forbids mixed declarations and code" ↵Michael Niedermayer2015-07-17
| | | | | | warnings Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avfilter: add Dynamic Audio Normalizer filterLoRd_MuldeR2015-07-17
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-10 23:23:41 +0000