summaryrefslogtreecommitdiff
path: root/libavcodec
Commit message (Collapse)AuthorAge
* avcodec: Undeprecate reordered_opaqueDiego Biurrun2014-08-07
| | | | | | | It allows attaching other external, opaque data to the frame and passing it through the reordering process, for cases when the caller wants other data than just the plain packet pts. There is no way to cleanly achieve this without the field.
* h264: fix interpretation of interleved stereo modesFelix Abecassis2014-08-07
| | | | | | Column and row frame packing arrangements were inverted. Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>
* svq1: do not modify the input packetAnton Khirnov2014-08-06
| | | | | | | | | | | The input data must remain constant, make a copy instead. This is in theory a performance hit, but since I failed to find any samples using this feature, this should not matter in practice. Also, check the size of the header, avoiding invalid reads on truncated data. CC:libav-stable@libav.org
* cdgraphics: do not return 0 from the decode functionAnton Khirnov2014-08-06
| | | | | | | 0 means no data consumed, so it can trigger an infinite loop in the caller. CC:libav-stable@libav.org
* cdgraphics: switch to bytestream2Anton Khirnov2014-08-06
| | | | | | | Fixes possible invalid memory accesses on corrupted data. CC:libav-stable@libav.org Bug-ID: CVE-2013-3674
* jpeg2000: enable 4 component pixel formatsVittorio Giovara2014-08-06
| | | | | | Bug-Id: 721 CC: libav-stable@libav.org Sample-Id: 31230.mov
* huffyuvdec: check width size for yuv422pMichael Niedermayer2014-08-05
| | | | | | | | | Avoid out of array accesses. CC: libav-stable@libav.org Bug-Id: CVE-2013-0848 Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com> Signed-off-by: Anton Khirnov <anton@khirnov.net>
* mmvideo: check horizontal coordinate tooMichael Niedermayer2014-08-05
| | | | | | | | | Fixes out of array accesses. Bug-Id: CVE-2013-3672 Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com> Signed-off-by: Anton Khirnov <anton@khirnov.net>
* wmalosslessdec: fix mclms_coeffs* array sizeMichael Niedermayer2014-08-05
| | | | | | | | | Fixes corruption of context Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC:libav-stable@libav.org Bug-Id: CVE-2014-2098 Signed-off-by: Anton Khirnov <anton@khirnov.net>
* vc-1: Optimise parser (with special attention to ARM)Ben Avison2014-08-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation of the parser made four passes over each input buffer (reduced to two if the container format already guaranteed the input buffer corresponded to frames, such as with MKV). But these buffers are often 200K in size, certainly enough to flush the data out of L1 cache, and for many CPUs, all the way out to main memory. The passes were: 1) locate frame boundaries (not needed for MKV etc) 2) copy the data into a contiguous block (not needed for MKV etc) 3) locate the start codes within each frame 4) unescape the data between start codes After this, the unescaped data was parsed to extract certain header fields, but because the unescape operation was so large, this was usually also effectively operating on uncached memory. Most of the unescaped data was simply thrown away and never processed further. Only step 2 - because it used memcpy - was using prefetch, making things even worse. This patch reorganises these steps so that, aside from the copying, the operations are performed in parallel, maximising cache utilisation. No more than the worst-case number of bytes needed for header parsing is unescaped. Most of the data is, in practice, only read in order to search for a start code, for which optimised implementations already existed in the H264 codec (notably the ARM version uses prefetch, so we end up doing both remaining passes at maximum speed). For MKV files, we know when we've found the last start code of interest in a given frame, so we are able to avoid doing even that one remaining pass for most of the buffer. In some use-cases (such as the Raspberry Pi) video decode is handled by the GPU, but the entire elementary stream is still fed through the parser to pick out certain elements of the header which are necessary to manage the decode process. As you might expect, in these cases, the performance of the parser is significant. To measure parser performance, I used the same VC-1 elementary stream in either an MPEG-2 transport stream or a MKV file, and fed it through avconv with -c:v copy -c:a copy -f null. These are the gperftools counts for those streams, both filtered to only include vc1_parse() and its callees, and unfiltered (to include the whole binary). Lower numbers are better: Before After File Filtered Mean StdDev Mean StdDev Confidence Change M2TS No 861.7 8.2 650.5 8.1 100.0% +32.5% MKV No 868.9 7.4 731.7 9.0 100.0% +18.8% M2TS Yes 250.0 11.2 27.2 3.4 100.0% +817.9% MKV Yes 149.0 12.8 1.7 0.8 100.0% +8526.3% Yes, that last case shows vc1_parse() running 86 times faster! The M2TS case does show a larger absolute improvement though, since it was worse to begin with. This patch has been tested with the FATE suite (albeit on x86 for speed). Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
* vc-1: Add platform-specific start code search routine to VC1DSPContext.Ben Avison2014-08-04
| | | | | | | Initialise VC1DSPContext for parser as well as for decoder. Note, the VC-1 code doesn't actually use the function pointer yet. Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
* h264: Move start code search functions into separate source files.Ben Avison2014-08-04
| | | | | | This permits re-use with parsers for codecs which use similar start codes. Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
* avcodec: Suppress deprecation warnings from DTG code scheduled for removalDiego Biurrun2014-08-04
|
* tiff: support reading gray+alpha at 8 bitsCarl Eugen Hoyos2014-08-04
| | | | Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>
* tiff: support reading gray+alpha at 16 bitsVittorio Giovara2014-08-04
|
* png: support reading gray+alpha at 16 bitsVittorio Giovara2014-08-04
|
* png: disable broken MMX/SIMD code for bpp <= 2Vittorio Giovara2014-08-04
| | | | | The decoder was producing different results when ASM was disabled. Based on a long debug session with Kostya.
* avutil: rename AV_PIX_FMT_Y400A to AV_PIX_FMT_YA8Vittorio Giovara2014-08-04
| | | | | | | The rationale is that you have a packed format in form <greyscale sample> <alpha sample> <greyscale sample> <alpha sample> and shortening greyscale to 'G' might make one thing about Greenscale instead. An alias pixel format and color space name are provided for compatibility.
* avcodec: Deprecate dtg_active_format field in favor of avframe side-dataKieran Kunhya2014-08-03
| | | | Signed-off-by: Diego Biurrun <diego@biurrun.de>
* huffyuv: Check and propagate function return valuesDiego Biurrun2014-08-03
| | | | | | | | | | Bug-Id: CVE-2013-0868 inspired by a patch from Michael Niedermayer <michaelni@gmx.at> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Diego Biurrun <diego@biurrun.de> CC: libav-stable@libav.org
* huffyuv: Return proper error codesDiego Biurrun2014-08-03
|
* huffyuv: Use avpriv_report_missing_feature() where appropriateDiego Biurrun2014-08-03
|
* huffyuv: Eliminate some pointless castsDiego Biurrun2014-08-03
|
* huffyuv: K&R formatting cosmeticsDiego Biurrun2014-08-03
|
* mpeg4video: Initialize xvididct for all threadsAnton Khirnov2014-08-03
| | | | Signed-off-by: Diego Biurrun <diego@biurrun.de>
* aarch64: add ',' between assembler macro arguments where missingJanne Grunau2014-08-04
| | | | | | | llvm's integrated assembler does not accept spaces as macro argument delimiter when targeting darwin. Using a explicit delimiter is a good idea in principle since it makes case like 'macro 4 -2' vs 'macro 4 - 2' clear.
* avcodec: Deprecate unused defines and optionsDiego Biurrun2014-08-03
|
* avcodec: options: Add missing deprecation ifdefs around emu_edgeDiego Biurrun2014-08-03
|
* lcl: Disentangle pointers to input data and decompression bufferDiego Biurrun2014-08-03
| | | | This is cleaner and avoids a cast plus a related const qualifier warning.
* tiff: Replace deprecated PIX_FMT names by modern onesDiego Biurrun2014-08-02
|
* dv: Update DV-profile-related functions to current public APIDiego Biurrun2014-08-02
|
* ppc: fft: Build AltiVec optimizations in the standard wayDiego Biurrun2014-08-02
|
* h264: prevent theoretical infinite loop in SEI parsingVittorio Giovara2014-08-01
| | | | | | | Properly address CVE-2011-3946 and parse bitstream as described in the spec. CC: libav-stable@libav.org Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
* pngdec: correctly indent macrosVittorio Giovara2014-08-01
|
* tscc: Eliminate pointless variable indirections in decode_frame()Diego Biurrun2014-08-01
|
* pngenc: Drop pointless pointer cast in png_write_row()Diego Biurrun2014-08-01
|
* idct: Split off Xvid IDCTDiego Biurrun2014-08-01
| | | | | The Xvid IDCT is only required to decode some Xvid-encoded MPEG-4 files, so there is no point in having it as an unconditional part of idctdsp.
* ppc: idctdsp: Immediately return if no AltiVec is availableDiego Biurrun2014-08-01
| | | | This is how all the other init functions operate.
* pgssubdec: Check RLE size before copyingMichael Niedermayer2014-08-01
| | | | | | | | | | | | | Make sure the buffer size does not exceed the expected RLE size. Prevent an out of array bound write. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at> Bug-Id: CVE-2013-0852 Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
* mpegvideo: move vol_control_parameters to the only place it is usedNidhi Makhijani2014-07-29
| | | | Signed-off-by: Diego Biurrun <diego@biurrun.de>
* sanm: Use correct printf conversion specifiers for POSIX int typesDiego Biurrun2014-07-28
|
* x86: build: Restore ordering of OBJS linesDiego Biurrun2014-07-28
|
* hevc: eliminate the last element from TransformTreeAnton Khirnov2014-07-28
| | | | Replace it by passing an additional parameter to transform_unit()
* hevc: eliminate unnecessary cbf_c{b,r} arraysAnton Khirnov2014-07-28
| | | | | They are replaced by passing additional parameters to the transform functions.
* hevc: do not store the transform inter_split flag in the contextAnton Khirnov2014-07-28
| | | | It does not need to be preserved.
* hevc: simplify splitting the transform tree blocksAnton Khirnov2014-07-28
|
* hevc: eliminate an unnecessary arrayAnton Khirnov2014-07-28
| | | | We do not need to store the value of the split flag.
* codec_desc: fix some typos in long codec namesAnton Khirnov2014-07-28
| | | | The rv20 typo spotted by Hendrik Leppkes <h.leppkes@gmail.com>
* lavc: add a property for marking codecs that support frame reorderingAnton Khirnov2014-07-28
|
* eamad: use the bytestream2 API instead of AV_RLAnton Khirnov2014-07-27
| | | | | | This is safer and possibly fixes invalid reads on truncated data. CC:libav-stable@libav.org