summaryrefslogtreecommitdiff
path: root/libavcodec/mediacodecdec.c
Commit message (Collapse)AuthorAge
* avcodec/mediacodecdec: add workaround for buggy amlogic mpeg2 decoderAman Gupta2018-05-04
| | | | | | | | | | | | | | | | | | I tested the previous mediacodec changes on seven different Android TV devices, with both mpeg2 and h264 content. All except one worked as expected. The exception was the MiBox3 running Android 6.0.1, where playback would freeze on a frame every few seconds. I tested two other AMLogic devices with newer Android versions that did not show the same problem. H264 decoding on the MiBox3 was also not affected, so this workaround applies only to OMX.amlogic.mpeg2.decoder.awesome on Android API22. There is a rumor that Xiaomi is planning to release Android Oreo for the MiBox3, so I will revisit in a few months to confirm whether this is specific to os/driver version or the chipset used in that device. Signed-off-by: Aman Gupta <aman@tmm1.net> Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* avcodec/mediacodecdec: restructure mediacodec_receive_frameAman Gupta2018-05-04
| | | | | | | | | | | | | The new logic follows a recommendation by @rcombs to use dequeueInputBuffer with a timeout of 0 as a way to detect whether the codec wants more data. The dequeued buffer index is kept in MediaCodecDecContext until it can be used next. A similar technique is also used by the Google's official media player Exoplayer: see MediaCodecRenderer.feedInputBuffer(). Signed-off-by: Aman Gupta <aman@tmm1.net> Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* avcodec/mediacodecdec: clarify delay_flush specific codeAman Gupta2018-04-25
| | | | | | | | | As of 2a0eb8685, ff_mediacodec_dec_is_flushing() only returns true in delay_flush mode. Make this more obvious by adding delay_flush to the if statement. Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com> Signed-off-by: Aman Gupta <aman@tmm1.net>
* avcodec/mediacodecdec: fix immediate EAGAIN with buffered packetAman Gupta2018-03-13
| | | | | | | | | | | | | | In cases where the mediacodec decoder consumed a partial packet, receive_frame() would start returning EAGAIN if the rest of the packet couldn't be flushed and no frames were immediately available. This fixes receive_frame() to perform its normal blocking wait for new frames before returning EAGAIN. Fixes an issue I could reproduce fairly often on a FireOS 6 device, and reported to be happening intermittently by two mpv users. Signed-off-by: Aman Gupta <aman@tmm1.net> Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* avcodec/mediacodecdec: add delay_flush optionAman Gupta2018-03-07
| | | | | | | | | | | | | | | | | | | | | | | | The default behavior of the mediacodec decoder before this commit was to delay flushes until all pending hardware frames were returned to the decoder. This was useful for certain types of applications, but was unexpected behavior for others. The new default behavior with this commit is now to execute flushes immediately to invalidate all pending frames. The old behavior can be enabled by setting delay_flush=1. With the new behavior, video players implementing seek can simply call flush on the decoder without having to worry about whether they have one or more mediacodec frames still buffered in their rendering pipeline. Previously, all these frames had to be explictly freed (or rendered) before the seek/flush would execute. The new behavior matches the behavior of all other lavc decoders, reducing the amount of special casing required when using the mediacodec decoder. Signed-off-by: Aman Gupta <aman@tmm1.net> Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* avcodec/mediacodecdec: factorize codec declarationsMatthieu Bouron2018-03-03
|
* avcodec/mediacodecdec: factorize common extradata functionsMatthieu Bouron2018-03-03
|
* avcodec/mediacodecdec: add missing "libavutil/internal.h" includeMatthieu Bouron2018-03-03
| | | | libavutil/internal.h defines NULL_IF_CONFIG_SMALL.
* avcodec/mediacodecdec: refactor to take advantage of new decoding apiAman Gupta2018-02-19
| | | | | | | | | | | | | | | | | | | | This refactor splits up the main mediacodec decode loop into two send/receive helpers, which are then used to rewrite the receive_frame callback and take full advantage of the new decoding api. Since we can now request packets on demand with ff_decode_get_packet(), the fifo buffer is no longer necessary and has been removed. This change was motivated by behavior observed on certain Android TV devices, featuring hardware mpeg2/h264 decoders which also deinterlace content (to produce multiple frames per field). Previously, this code caused buffering issues because queueInputBuffer() was always invoked before each dequeueOutputBuffer(), even though twice as many output buffers were being generated. With this patch, the decoder will always attempt to drain new frames first before sending more data into the underlying codec. Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* avcodec/mediacodecdec: use ff_hevc_ps_uninit()James Almer2018-01-30
| | | | | | Fixes memleaks. Signed-off-by: James Almer <jamrial@gmail.com>
* lavc/mediacodecdec: remove mediacodec_process_data() indirectionMatthieu Bouron2018-01-06
|
* lavc/mediacodecdec: switch to new decoding APIAman Gupta2018-01-06
| | | | | | | | | | Using the new API gives the decoder the ability to produce N frames per input packet. This is particularly useful with mpeg2 decoders on some android devices, which automatically deinterlace video and produce one frame per field. Signed-off-by: Aman Gupta <aman@tmm1.net> Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* lavc/mediacodec: use AVMediaCodecDeviceContext hw_device_ctx if setAman Gupta2017-12-16
| | | | Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* avcodec: add metadata to identify wrappers and hardware decoderswm42017-12-14
| | | | | | | | | | | | | | | | | | | | | Explicitly identify decoder/encoder wrappers with a common name. This saves API users from guessing by the name suffix. For example, they don't have to guess that "h264_qsv" is the h264 QSV implementation, and instead they can just check the AVCodec .codec and .wrapper_name fields. Explicitly mark AVCodec entries that are hardware decoders or most likely hardware decoders with new AV_CODEC_CAPs. The purpose is allowing API users listing hardware decoders in a more generic way. The proposed AVCodecHWConfig does not provide this information fully, because it's concerned with decoder configuration, not information about the fact whether the hardware is used or not. AV_CODEC_CAP_HYBRID exists specifically for QSV, which can have software implementations in case the hardware is not capable. Based on a patch by Philip Langdale <philipl@overt.org>. Merges Libav commit 47687a2f8aca3f65b6fdd117b1cb66a7409a7fd1.
* mediacodecdec: fix build by including hwaccel.hJan Ekström2017-12-01
| | | | Enables the decoder to utilize the type AVCodecHWConfigInternal.
* lavc: Add hardware config metadata for decoders supporting hardware outputMark Thompson2017-11-26
| | | | | | | | | This includes a pointer to the associated hwaccel for decoders using hwaccels - these will be used later to implement the hwaccel setup without needing a global list. Also added is a new file listing all hwaccels as external declarations - this will be used later to generate the hwaccel list at configure time.
* avcodec/hevc_sei: rename HEVCSEIContext to HEVCSEIJames Almer2017-10-31
| | | | | | | Cosmetic change skipped in 0b30cb8dae5e7edb2a5f35900547321499c217f1 by mistake. Signed-off-by: James Almer <jamrial@gmail.com>
* lavc/mediacodecdec: switch to the new generic filtering mechanismMatthieu Bouron2017-06-13
|
* lavc: add mpeg2 mediacodec decoderAman Gupta2017-06-08
| | | | | | | Android TV and FireOS hardware supports mpeg2 hardware decoding via MediaCodec. Signed-off-by: Matthieu Bouron <matthieu.bouron@gmail.com>
* avcodec/hevc_parse: decode SEI message NALUs in extradataJames Almer2017-05-05
| | | | | | | | | | They may be available in hvcc style extradata. Based on a patch by Hendrik Leppkes. Reviewed-by: Hendrik Leppkes <h.leppkes@gmail.com> Reviewed-by: Aaron Levinson <alevinsn@aracnet.com> Signed-off-by: James Almer <jamrial@gmail.com>
* avcodec/hevc_parse: allow setting apply_defdispwin when decoding SPS NAL unitsJames Almer2017-04-09
| | | | | Reviewed-by: nevcairiel Signed-off-by: James Almer <jamrial@gmail.com>
* lavc/mediacodecdec: set AV_CODEC_CAP_AVOID_PROBING capabilityMatthieu Bouron2017-04-04
|
* lavc/mediacodecdec: switch to AV_CODEC_CAP_DELAYMatthieu Bouron2017-04-04
|
* Merge commit 'c359d624d3efc3fd1d83210d78c4152bd329b765'James Almer2017-03-23
| | | | | | | * commit 'c359d624d3efc3fd1d83210d78c4152bd329b765': hevcdec: move decoder-independent declarations into a separate header Merged-by: James Almer <jamrial@gmail.com>
* avcodec/mediacodec: convert to stdatomicJames Almer2017-03-23
| | | | | Reviewed-by: wm4 <nfxjfg@googlemail.com> Signed-off-by: James Almer <jamrial@gmail.com>
* lavc/mediacodec: use more meaningful filenamesMatthieu Bouron2016-10-19
| | | | | | Adds the following changes: * mediacodecdec.{c,h} -> mediacodecdec_common.{c,h} * mediacodecdec_h2645.c -> mediacodecdec.c
* lavc: add mpeg4 mediacodec decoderMatthieu Bouron2016-10-19
|
* lavc: add vp8/vp9 mediacodec decodersMatthieu Bouron2016-10-19
|
* lavc/mediacodecdec: rename dequeued_buffer_nb to output_buffer_countMatthieu Bouron2016-10-12
|
* lavc/mediacodecdec: remove first output buffer timing debug logMatthieu Bouron2016-10-12
|
* Merge commit '32c8359093d1ff4f45ed19518b449b3ac3769d27'Hendrik Leppkes2016-10-07
| | | | | | | * commit '32c8359093d1ff4f45ed19518b449b3ac3769d27': lavc: export the timestamps when decoding in AVFrame.pts Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>
* lavc/mediacodecdec: fix size variable shadowing in ff_mediacodec_dec_decodeMatthieu Bouron2016-10-06
| | | | Fixes incompatible pointer type warning on 64-bit systems.
* lavc: add hevc mediacodec decoderMatthieu Bouron2016-09-15
|
* lavc: add mediacodec hwaccel supportMatthieu Bouron2016-07-08
|
* lavc/mediacodec: increase buffer dequeue timeout when the codec needs to be ↵Matthieu Bouron2016-06-23
| | | | | | | | | | | drained Increase buffer dequeue timeout when the codec needs to be drained as it could happen that no input buffer is available when we receive a null packet for the first time (meaning we are unable to signal end of stream and mark the codec as draining). Fixes potential loss of last frames after sending a null packet.
* lavc/mediacodec: rely on buffer flags to detect end of streamMatthieu Bouron2016-06-23
|
* lavc/mediacodec: re-indent after previous commitMatthieu Bouron2016-06-23
|
* lavc/mediacodec: discard 0-sized buffersMatthieu Bouron2016-06-23
| | | | Their only purpose is to carry the end of stream flag.
* lavc/mediacodecdec{,_h264}: set FF_CODEC_CAP_SETS_PKT_DTS capabilityMatthieu Bouron2016-06-20
| | | | | | And sets frames pkt_dts to AV_NOPTS_VALUE as we do not want lavc/utils to overwrite the field with incorrect values as the decoder is asynchronous.
* lavc/mediacodec: refactor ff_AMediaCodecList_getCodecByTypeMatthieu Bouron2016-06-15
| | | | | | | | | | | | | Allows to select a codec (encoder or decoder) only if it supports a specific profile. Adds ff_AMediaCodecProfile_getProfileFromAVCodecContext to convert an AVCodecContext profile to a MediaCodec profile. It only supports H264 for now. The codepath using MediaCodecList.findDecoderForFormat() (Android >= 5.0) has been dropped as this method does not allow to select a decoder compatible with a specific profile.
* lavc/mediacodec: improve error messagesMatthieu Bouron2016-06-07
|
* lavc/mediacodec: bypass width/height restrictions when looking for a decoderMatthieu Bouron2016-06-07
| | | | | | | | | Codec width/height restrictions seem hardcoded at the OMX level and seem arbitrary. Bypassing those restrictions allows a device to decode streams at higher resolutions. For example it allows a Nexus 5 to decode h264 streams with a resolution higher than 1920x1080.
* lavc/mediacodec: fix zero stride for OMX.allwinner.video.decoder.avcKirill Gavrilov2016-03-28
|
* lavc/mediacodec: use ternary operator to set slice-height valueMatthieu Bouron2016-03-28
|
* lavc/mediacodec: remove stray empty linesMatthieu Bouron2016-03-15
|
* lavc/mediacodec: fix codec_name leakMatthieu Bouron2016-03-15
|
* lavc: add h264 mediacodec decoderMatthieu Bouron2016-03-07