summaryrefslogtreecommitdiff
path: root/libavcodec/dirac_vlc.c
Commit message (Collapse)AuthorAge
* avcodec/dirac_vlc: limit res_bits in APPEND_RESIDUE()Michael Niedermayer2017-09-09
| | | | | | | | | | Fixes: runtime error: left shift of 1073741838 by 1 places cannot be represented in type 'int32_t' (aka 'int') Fixes: 3279/clusterfuzz-testcase-minimized-4564805744590848 Suggested-by: <atomnuker> Reviewed-by: <atomnuker> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avcodec/dirac_vlc: Fix invalid shift in ff_dirac_golomb_read_32bit()Michael Niedermayer2017-09-02
| | | | | | | | Fixes: runtime error: shift exponent 64 is too large for 64-bit type 'residual' (aka 'unsigned long') Fixes: 2838/clusterfuzz-testcase-minimized-6260066086813696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avcodec/dirac_vlc: Fix invalid shiftMichael Niedermayer2017-08-01
| | | | | | | | Fixes: runtime error: shift exponent 65 is too large for 64-bit type 'residual' (aka 'unsigned long') Fixes: 2737/clusterfuzz-testcase-minimized-4968639147016192 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avcodec/dirac_vlc: Fix undefined shiftMichael Niedermayer2017-07-24
| | | | | | | | Fixes: runtime error: shift exponent 64 is too large for 64-bit type 'residual' (aka 'unsigned long') Fixes: 2674/clusterfuzz-testcase-minimized-4999700518273024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* dirac_vlc: prevent shifting a 0 by 64 bits when zeroing residueRostislav Pehlivanov2016-07-14
| | | | | | | Adding a check for bits == 0 would still make Coverity misdetect this, so just revert to the normal way of setting the residue to 0. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
* dirac_vlc: add a SET_RESIDUE macro and fix recent regressionRostislav Pehlivanov2016-07-14
| | | | | | | Can also be used in future cleanups since 99% of the time the leftover appending will just append to an already empty residue. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
* dirac_vlc: remove redundant macro declarationRostislav Pehlivanov2016-07-13
| | | | Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
* dirac_vlc: fix undefined shiftsRostislav Pehlivanov2016-07-13
| | | | | | | | | Shifting by more than 63 bits is undefined behavior, athough any compiler not returning 0 after shifting by any amount would be insane. Found by Coverity, fixes CID1363959 and CID1363960 Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
* avcodec/dirac_vlc: Fix mixed declaration and statementsMichael Niedermayer2016-07-12
| | | | Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* diracdec: implement a LUT-based Golomb code parserRostislav Pehlivanov2016-07-11
Still much left to optimize, but it provides a significant performance improvement - 10% for 300Mbps (1080p30), 25% for 1.5Gbps (4k 60fps) in comparison with the default implementation. Signed-off-by: Rostislav Pehlivanov <rpehlivanov@obe.tv>