diff options
| author | Derek Buitenhuis <derek.buitenhuis@gmail.com> | 2021-08-02 21:50:44 +0100 |
|---|---|---|
| committer | Derek Buitenhuis <derek.buitenhuis@gmail.com> | 2021-08-06 15:48:31 +0100 |
| commit | e6754d2ad20c918735d3bf5cc8122ac57f53d03c (patch) | |
| tree | 0d1662df6d73b57160ed9c89cfefa3dde2338e7d /tests | |
| parent | 1cd43d8a5ebc58e74937ed2f65600790f5697d0c (diff) | |
ffprobe: Rename Audio Service Type 'type' field to 'service_type'
677a030b26045acb50353d7954ae984ceefcd807 introduced more printable
side data types in ffprobe, however the Audio Service Type side data
'type' field that was introduced aliases an existing field of the same
name within the side data array, which can lead to JSON output like:
"side_data_list": [
{
"side_data_type": "Audio Service Type",
"type": 0
},
{
"side_data_type": "Stereo 3D",
"type": "side by side",
"inverted": 1
}
]
This, while technically valid JSON, is considered bad practice, since it
forces all downstream users to manually parse it and check all types;
it makes simple deserialization impossible. Worse, in som loosely
type languages, it can lead to silent bugs if exising code assumed
it was a different type.
As such, rename this second "type" field to "service_type".
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/ref/fate/hls-fmp4_ac3 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/ref/fate/hls-fmp4_ac3 b/tests/ref/fate/hls-fmp4_ac3 index ce7367de4d..cbe3ea1f1f 100644 --- a/tests/ref/fate/hls-fmp4_ac3 +++ b/tests/ref/fate/hls-fmp4_ac3 @@ -5,6 +5,6 @@ channels=6 channel_layout=5.1(side) [SIDE_DATA] side_data_type=Audio Service Type -type=0 +service_type=0 [/SIDE_DATA] [/STREAM] |