summaryrefslogtreecommitdiff
path: root/libavformat/utils.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2018-09-27 00:00:24 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2018-10-07 03:03:09 +0200
commitbeb3aea48e5f8a3d57f244fb8998ddf04928ee81 (patch)
tree1b7df61b9013040df02c21758cde82b225f2e666 /libavformat/utils.c
parentfd3eda40308ebc4eae02d2a0877edb8aeb206a5f (diff)
avformat/utils: Do not ignore failure in extract_extradata_init()
We check for the documented explanation of the "Ignore code" in extract_extradata_check() already Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavformat/utils.c')
-rw-r--r--libavformat/utils.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/libavformat/utils.c b/libavformat/utils.c
index c973a7e0c5..7e5783c14c 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -3489,13 +3489,9 @@ static int extract_extradata_init(AVStream *st)
i->extract_extradata.bsf->time_base_in = st->time_base;
- /* if init fails here, we assume extracting extradata is just not
- * supported for this codec, so we return success */
ret = av_bsf_init(i->extract_extradata.bsf);
- if (ret < 0) {
- av_bsf_free(&i->extract_extradata.bsf);
- ret = 0;
- }
+ if (ret < 0)
+ goto fail;
finish:
i->extract_extradata.inited = 1;