summaryrefslogtreecommitdiff
path: root/libavformat/rtmpproto.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2011-09-21 01:05:36 +0200
committerMichael Niedermayer <michaelni@gmx.at>2011-09-21 01:05:36 +0200
commit7cb5def1f38d2d1d801c5425a6c79be425e40196 (patch)
tree8c6ffc9889592a6dcfa512c3292b52c446d0d9f1 /libavformat/rtmpproto.c
parentc83442b0571370b946d3f8bb85c46879d62ab10a (diff)
parent3ffe32eb96e2414bdd87b353953d77fb83eca8ae (diff)
Merge remote-tracking branch 'qatar/master'
* qatar/master: rtmp: Don't blindly skip the 4 trailer bytes from the FLV packets rtmp: Handle FLV packets written in more than one write call rv34: Check for invalid slice offsets Conflicts: libavformat/rtmpproto.c Merged-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavformat/rtmpproto.c')
-rw-r--r--libavformat/rtmpproto.c24
1 files changed, 20 insertions, 4 deletions
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 61be5faaf5..920ca44c34 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -71,6 +71,7 @@ typedef struct RTMPContext {
uint32_t client_report_size; ///< number of bytes after which client should report to server
uint32_t bytes_read; ///< number of bytes read from server
uint32_t last_bytes_read; ///< number of bytes read last reported to server
+ int skip_bytes; ///< number of bytes to skip from the input FLV stream in the next write call
} RTMPContext;
#define PLAYER_KEY_OPEN_PART_LEN 30 ///< length of partial key used for first client digest signing
@@ -925,7 +926,16 @@ static int rtmp_write(URLContext *s, const uint8_t *buf, int size)
uint32_t ts;
const uint8_t *buf_temp = buf;
- if (!rt->flv_off && size < 11) {
+ if (rt->skip_bytes) {
+ int skip = FFMIN(rt->skip_bytes, size);
+ buf_temp += skip;
+ size_temp -= skip;
+ rt->skip_bytes -= skip;
+ if (size_temp <= 0)
+ return size;
+ }
+
+ if (!rt->flv_off && size_temp < 11) {
av_log(s, AV_LOG_DEBUG, "FLV packet too small %d\n", size);
return 0;
}
@@ -969,13 +979,19 @@ static int rtmp_write(URLContext *s, const uint8_t *buf, int size)
size_temp = 0;
} else {
bytestream_get_buffer(&buf_temp, rt->flv_data + rt->flv_off, rt->flv_size - rt->flv_off);
+ size_temp -= rt->flv_size - rt->flv_off;
rt->flv_off += rt->flv_size - rt->flv_off;
- size_temp -= (rt->flv_size - rt->flv_off);
}
if (rt->flv_off == rt->flv_size) {
- bytestream_get_be32(&buf_temp);
- size_temp -= 4;
+ if (size_temp < 4) {
+ rt->skip_bytes = 4 - size_temp;
+ buf_temp += size_temp;
+ size_temp = 0;
+ } else {
+ bytestream_get_be32(&buf_temp);
+ size_temp -= 4;
+ }
ff_rtmp_packet_write(rt->stream, &rt->out_pkt, rt->chunk_size, rt->prev_pkt[1]);
ff_rtmp_packet_destroy(&rt->out_pkt);
rt->flv_size = 0;