summaryrefslogtreecommitdiff
path: root/libavformat/http.c
diff options
context:
space:
mode:
authorRonald S. Bultje <rsbultje@gmail.com>2009-03-03 13:26:17 +0000
committerRonald S. Bultje <rsbultje@gmail.com>2009-03-03 13:26:17 +0000
commitd176f9038711e497b32f1431e60e4e3da94179d1 (patch)
tree0c1d74af15c627958f5502180428f555f9ed3390 /libavformat/http.c
parent429d6b2180c2a314cc2fa9b6f068910516335bda (diff)
Reduce allocated length of the HTTP authentication request field buffer, as
noticed by Stefano and Luca in the "[PATCH]RTSP Basic Authentication" mailinglist thread. av_base64_encode() was recently changed. The previous implementation required 12 extra bytes (ceil(len(src)/3.)*4+12), whereas the new one is guaranteed to fit in an exact buffer (ceil(len(src)/3.)*4), plus one extra byte for the trailing zero. This change fixes no bug, it just slightly decreases the amount of allocated memory. Originally committed as revision 17761 to svn://svn.ffmpeg.org/ffmpeg/trunk
Diffstat (limited to 'libavformat/http.c')
-rw-r--r--libavformat/http.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/http.c b/libavformat/http.c
index 2e6a1db20a..039ef7bbc5 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -212,7 +212,7 @@ static int http_connect(URLContext *h, const char *path, const char *hoststr,
int post, err, ch;
char line[1024], *q;
char *auth_b64;
- int auth_b64_len = strlen(auth)* 4 / 3 + 12;
+ int auth_b64_len = (strlen(auth) + 2) / 3 * 4 + 1;
int64_t off = s->off;