diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-08-03 00:59:02 +0200 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-08-07 09:21:13 +0200 |
| commit | 50ea7389ecae321ea6c4c585b8f721b84bd64a1d (patch) | |
| tree | 87f92b2b059f2ca17392f5dceca05c14d1859934 /libavfilter/avf_showcqt.c | |
| parent | 6b82f35041fd3229f056e9b8644e8a91d0e0bc19 (diff) | |
avfilter: Deduplicate default audio inputs/outputs
Lots of audio filters use very simple inputs or outputs:
An array with a single AVFilterPad whose name is "default"
and whose type is AVMEDIA_TYPE_AUDIO; everything else is unset.
Given that we never use pointer equality for inputs or outputs*,
we can simply use a single AVFilterPad instead of dozens; this
even saves .data.rel.ro (4784B here) as well as relocations.
*: In fact, several filters (like the filters in af_biquads.c)
already use the same inputs; furthermore, ff_filter_alloc()
duplicates the input and output pads so that we do not even
work with the pads directly.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavfilter/avf_showcqt.c')
| -rw-r--r-- | libavfilter/avf_showcqt.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c index fa3cdaf22b..21948db339 100644 --- a/libavfilter/avf_showcqt.c +++ b/libavfilter/avf_showcqt.c @@ -26,6 +26,7 @@ #include "libavutil/eval.h" #include "libavutil/pixdesc.h" #include "libavutil/time.h" +#include "audio.h" #include "avfilter.h" #include "filters.h" #include "internal.h" @@ -1591,13 +1592,6 @@ static int activate(AVFilterContext *ctx) return FFERROR_NOT_READY; } -static const AVFilterPad showcqt_inputs[] = { - { - .name = "default", - .type = AVMEDIA_TYPE_AUDIO, - }, -}; - static const AVFilterPad showcqt_outputs[] = { { .name = "default", @@ -1613,7 +1607,7 @@ const AVFilter ff_avf_showcqt = { .activate = activate, .uninit = uninit, .priv_size = sizeof(ShowCQTContext), - FILTER_INPUTS(showcqt_inputs), + FILTER_INPUTS(ff_audio_default_filterpad), FILTER_OUTPUTS(showcqt_outputs), FILTER_QUERY_FUNC(query_formats), .priv_class = &showcqt_class, |