summaryrefslogtreecommitdiff
path: root/libavcodec
diff options
context:
space:
mode:
authorwm4 <nfxjfg@googlemail.com>2015-05-14 18:27:31 +0200
committerMichael Niedermayer <michaelni@gmx.at>2015-05-14 18:58:56 +0200
commitcc5e4bb48476a89cc8ce0c41bc2bd2e8fda9b37c (patch)
tree18d497e40c4f5ca8dbbd7273ec04f6388654ce0c /libavcodec
parentf6b8b966076fcd358f734c6d00ed642edc02b4cd (diff)
hevc: make avcodec_decode_video2() fail if get_format() fails
Personally, I need the decoder to back out if get_format() returns no usable pixel format. This didn't work because the error code was not propagated down the call chain. This in turn happened because the variable declaration removed in this patch shadowed the variable, whose value is returned at the end of the function. Consequently, failures of decode_nal_unit() were ignored in this place. Reviewed-by: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavcodec')
-rw-r--r--libavcodec/hevc.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c
index 459030c7e1..199a3b9850 100644
--- a/libavcodec/hevc.c
+++ b/libavcodec/hevc.c
@@ -3000,7 +3000,6 @@ static int decode_nal_units(HEVCContext *s, const uint8_t *buf, int length)
/* parse the NAL units */
for (i = 0; i < s->nb_nals; i++) {
- int ret;
s->skipped_bytes = s->skipped_bytes_nal[i];
s->skipped_bytes_pos = s->skipped_bytes_pos_nal[i];