summaryrefslogtreecommitdiff
path: root/libavcodec
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2019-01-15 00:02:25 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2019-01-28 01:09:38 +0100
commitc95d0fb23917c35886f3b62daa05af20d2700a1e (patch)
treed439c2fe4d8374d9e4be96ca3434341129205c48 /libavcodec
parent3016e1f8c53d2b035810684a18159bf5a8d47399 (diff)
avcodec/ilbcdec: Fix integer overflow in construct_vector()
webrtc contains explicit code to ignore the undefined behavior (RTC_NO_SANITIZE / OverflowingAddS32S32ToS32()) Probably fixes: Integer overflow (unreproducable here) Probably fixes: 12215/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-5767142427852800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec')
-rw-r--r--libavcodec/ilbcdec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/ilbcdec.c b/libavcodec/ilbcdec.c
index 50012c0231..643547f4ab 100644
--- a/libavcodec/ilbcdec.c
+++ b/libavcodec/ilbcdec.c
@@ -745,7 +745,7 @@ static void construct_vector (
for (j = 0; j < veclen; j++) {
a32 = SPL_MUL_16_16(*gainPtr++, cbvec0[j]);
a32 += SPL_MUL_16_16(*gainPtr++, cbvec1[j]);
- a32 += SPL_MUL_16_16(*gainPtr, cbvec2[j]);
+ a32 += (unsigned)SPL_MUL_16_16(*gainPtr, cbvec2[j]);
gainPtr -= 2;
decvector[j] = (a32 + 8192) >> 14;
}