summaryrefslogtreecommitdiff
path: root/libavcodec/wavpack.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2011-09-09 22:00:50 +0200
committerMichael Niedermayer <michaelni@gmx.at>2011-09-09 22:01:31 +0200
commit22bf6f7054d46e942ab02d434d3af6c08875576b (patch)
tree1a786ebf686460901932d06739217210f8973ed4 /libavcodec/wavpack.c
parent1bb766a988e5038b7e5c9c1e9ef787ec1dfc80cb (diff)
parentdba2b63a98bdcac7bda1a8a2c48950518c075e17 (diff)
Merge remote-tracking branch 'qatar/master'
* qatar/master: wavpack: Check error codes rather than working around error conditions. Merged-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavcodec/wavpack.c')
-rw-r--r--libavcodec/wavpack.c13
1 files changed, 10 insertions, 3 deletions
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index 870437d6f4..582e2cf8c0 100644
--- a/libavcodec/wavpack.c
+++ b/libavcodec/wavpack.c
@@ -1120,6 +1120,10 @@ static int wavpack_decode_block(AVCodecContext *avctx, int block_no,
samplecount = wv_unpack_stereo(s, &s->gb, samples, AV_SAMPLE_FMT_S32);
else
samplecount = wv_unpack_stereo(s, &s->gb, samples, AV_SAMPLE_FMT_FLT);
+
+ if (samplecount < 0)
+ return -1;
+
samplecount >>= 1;
}else{
const int channel_stride = avctx->channels;
@@ -1131,11 +1135,14 @@ static int wavpack_decode_block(AVCodecContext *avctx, int block_no,
else
samplecount = wv_unpack_mono(s, &s->gb, samples, AV_SAMPLE_FMT_FLT);
+ if (samplecount < 0)
+ return -1;
+
if(s->stereo && avctx->sample_fmt == AV_SAMPLE_FMT_S16){
int16_t *dst = (int16_t*)samples + 1;
int16_t *src = (int16_t*)samples;
int cnt = samplecount;
- while(cnt-- > 0){
+ while(cnt--){
*dst = *src;
src += channel_stride;
dst += channel_stride;
@@ -1144,7 +1151,7 @@ static int wavpack_decode_block(AVCodecContext *avctx, int block_no,
int32_t *dst = (int32_t*)samples + 1;
int32_t *src = (int32_t*)samples;
int cnt = samplecount;
- while(cnt-- > 0){
+ while(cnt--){
*dst = *src;
src += channel_stride;
dst += channel_stride;
@@ -1153,7 +1160,7 @@ static int wavpack_decode_block(AVCodecContext *avctx, int block_no,
float *dst = (float*)samples + 1;
float *src = (float*)samples;
int cnt = samplecount;
- while(cnt-- > 0){
+ while(cnt--){
*dst = *src;
src += channel_stride;
dst += channel_stride;