summaryrefslogtreecommitdiff
path: root/libavcodec/snow.h
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2014-08-30 02:12:10 +0200
committerMichael Niedermayer <michaelni@gmx.at>2014-08-30 02:12:10 +0200
commit596636a474ab201badaae269f3a2cef4824b8c1f (patch)
tree5178131dcc7239e4395af591f6cdd4536357c76f /libavcodec/snow.h
parentd9e2aceb7f1c712a52672129ca7971872b030e1e (diff)
avcodec/snow: check coeffs for validity
Fixes deadlock Fixes integer overflow Fixes Ticket 3892 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavcodec/snow.h')
-rw-r--r--libavcodec/snow.h9
1 files changed, 8 insertions, 1 deletions
diff --git a/libavcodec/snow.h b/libavcodec/snow.h
index 38810c11d3..0f75419b36 100644
--- a/libavcodec/snow.h
+++ b/libavcodec/snow.h
@@ -659,7 +659,10 @@ static inline void unpack_coeffs(SnowContext *s, SubBand *b, SubBand * parent, i
if(v){
v= 2*(get_symbol2(&s->c, b->state[context + 2], context-4) + 1);
v+=get_rac(&s->c, &b->state[0][16 + 1 + 3 + ff_quant3bA[l&0xFF] + 3*ff_quant3bA[t&0xFF]]);
-
+ if ((uint16_t)v != v) {
+ av_log(s->avctx, AV_LOG_ERROR, "Coefficient damaged\n");
+ v = 1;
+ }
xc->x=x;
(xc++)->coeff= v;
}
@@ -669,6 +672,10 @@ static inline void unpack_coeffs(SnowContext *s, SubBand *b, SubBand * parent, i
else run= INT_MAX;
v= 2*(get_symbol2(&s->c, b->state[0 + 2], 0-4) + 1);
v+=get_rac(&s->c, &b->state[0][16 + 1 + 3]);
+ if ((uint16_t)v != v) {
+ av_log(s->avctx, AV_LOG_ERROR, "Coefficient damaged\n");
+ v = 1;
+ }
xc->x=x;
(xc++)->coeff= v;