summaryrefslogtreecommitdiff
path: root/libavcodec/mpegvideo.c
diff options
context:
space:
mode:
authorDiego Biurrun <diego@biurrun.de>2007-10-22 15:13:10 +0000
committerDiego Biurrun <diego@biurrun.de>2007-10-22 15:13:10 +0000
commit3a994ca43b28fcb189ec7f870f188853e676b3f2 (patch)
treee22a3d9a2756c779912e1b35cc481def002bff36 /libavcodec/mpegvideo.c
parent8622613d9f74e0ce5e248905f3f554d26f6d6c06 (diff)
Clarify comment block and rewrite in better English.
Originally committed as revision 10837 to svn://svn.ffmpeg.org/ffmpeg/trunk
Diffstat (limited to 'libavcodec/mpegvideo.c')
-rw-r--r--libavcodec/mpegvideo.c22
1 files changed, 11 insertions, 11 deletions
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 21fa5ed794..e0022f74f3 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -843,17 +843,17 @@ int ff_find_unused_picture(MpegEncContext *s, int shared){
}
av_log(s->avctx, AV_LOG_FATAL, "Internal error, picture buffer overflow\n");
- /*we could return -1 but the codec would crash anyway, trying to draw
- into, a non existing frame, this is safer than waiting for a random crash
- also the return of this is never usefull, a encoder must only allocate
- as many as allowed in the spec which has no relation to how many lavc
- could allocate (and MAX_PICTURE_COUNT is always large enough for such
- valid streams)
- and a decoder has to check stream validity and remove frames if too many
- reference frames are around. waiting for "OOM" is not correct at all, it
- similarely has to replace missing reference frames by (interpolated/MC)
- frames anything else is a bug in the codec ...
- */
+ /* We could return -1, but the codec would crash trying to draw into a
+ * non-existing frame anyway. This is safer than waiting for a random crash.
+ * Also the return of this is never useful, an encoder must only allocate
+ * as much as allowed in the specification. This has no relationship to how
+ * much libavcodec could allocate (and MAX_PICTURE_COUNT is always large
+ * enough for such valid streams).
+ * Plus, a decoder has to check stream validity and remove frames if too
+ * many reference frames are around. Waiting for "OOM" is not correct at
+ * all. Similarly, missing reference frames have to be replaced by
+ * interpolated/MC frames, anything else is a bug in the codec ...
+ */
abort();
return -1;
}