summaryrefslogtreecommitdiff
path: root/libavcodec/mpc7.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2011-10-03 01:02:45 +0200
committerMichael Niedermayer <michaelni@gmx.at>2011-10-03 01:02:45 +0200
commit487e088e5e7f4cade6bce5e9a3cff28fce303af1 (patch)
treeb11de275564c0afeb4166c97acf6a9b4e0995dba /libavcodec/mpc7.c
parentcffd20b90ee6f35e37cdb51dd94e6b2174fd31b6 (diff)
parent5674d4b0a35a34b75e3533a8580e0b5a0a8895a7 (diff)
Merge remote-tracking branch 'qatar/master'
* qatar/master: mpc8: check output buffer size before decoding mpc7: return error if packet is too small. mpc7: check output buffer size before decoding nellymoserdec: allocate float_buf only when decoding to int16 nellymoserdec: use NELLY_BUF_LEN instead of 128 nellymoserdec: use NELLY_BLOCK_LEN instead of 64 when appropriate. nellymoserdec: allow user to request SAMPLE_FMT_FLT for output samples. nellymoser: check output buffer size before decoding win32: improve threading algorithm warning Conflicts: libavcodec/nellymoserdec.c Merged-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavcodec/mpc7.c')
-rw-r--r--libavcodec/mpc7.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/libavcodec/mpc7.c b/libavcodec/mpc7.c
index ba8828eb52..272e1b28ba 100644
--- a/libavcodec/mpc7.c
+++ b/libavcodec/mpc7.c
@@ -197,12 +197,19 @@ static int mpc7_decode_frame(AVCodecContext * avctx,
int i, ch;
int mb = -1;
Band *bands = c->bands;
- int off;
+ int off, out_size;
int bits_used, bits_avail;
memset(bands, 0, sizeof(bands));
if(buf_size <= 4){
av_log(avctx, AV_LOG_ERROR, "Too small buffer passed (%i bytes)\n", buf_size);
+ return AVERROR(EINVAL);
+ }
+
+ out_size = (buf[1] ? c->lastframelen : MPC_FRAME_SIZE) * 4;
+ if (*data_size < out_size) {
+ av_log(avctx, AV_LOG_ERROR, "Output buffer is too small\n");
+ return AVERROR(EINVAL);
}
bits = av_malloc(((buf_size - 1) & ~3) + FF_INPUT_BUFFER_PADDING_SIZE);
@@ -277,7 +284,7 @@ static int mpc7_decode_frame(AVCodecContext * avctx,
*data_size = 0;
return buf_size;
}
- *data_size = (buf[1] ? c->lastframelen : MPC_FRAME_SIZE) * 4;
+ *data_size = out_size;
return buf_size;
}