summaryrefslogtreecommitdiff
path: root/libavcodec/mediacodecdec_common.c
diff options
context:
space:
mode:
authorZhao Zhili <zhilizhao@tencent.com>2022-10-10 23:19:02 +0800
committerZhao Zhili <zhilizhao@tencent.com>2022-11-21 23:51:53 +0800
commit093c4373214f002decc73ce337450d7ec641b3f4 (patch)
tree8c4961eb731e6a654cc176b2ef60671f0d1bfe53 /libavcodec/mediacodecdec_common.c
parent3e288dbf56da7213b1ca656f19bd216a9ba90929 (diff)
avcodec/mediacodec: fix incorrect crop info
The crop info is optional, but used unconditionally. Co-authored-by: Aman Karmani <ffmpeg@tmm1.net> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
Diffstat (limited to 'libavcodec/mediacodecdec_common.c')
-rw-r--r--libavcodec/mediacodecdec_common.c16
1 files changed, 14 insertions, 2 deletions
diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c
index 2a605e7f5b..f430cfed31 100644
--- a/libavcodec/mediacodecdec_common.c
+++ b/libavcodec/mediacodecdec_common.c
@@ -487,8 +487,20 @@ static int mediacodec_dec_parse_format(AVCodecContext *avctx, MediaCodecDecConte
AMEDIAFORMAT_GET_INT32(s->crop_left, "crop-left", 0);
AMEDIAFORMAT_GET_INT32(s->crop_right, "crop-right", 0);
- width = s->crop_right + 1 - s->crop_left;
- height = s->crop_bottom + 1 - s->crop_top;
+ if (s->crop_right && s->crop_bottom) {
+ width = s->crop_right + 1 - s->crop_left;
+ height = s->crop_bottom + 1 - s->crop_top;
+ } else {
+ /* TODO: NDK MediaFormat should try getRect() first.
+ * Try crop-width/crop-height, it works on NVIDIA Shield.
+ */
+ AMEDIAFORMAT_GET_INT32(width, "crop-width", 0);
+ AMEDIAFORMAT_GET_INT32(height, "crop-height", 0);
+ }
+ if (!width || !height) {
+ width = s->width;
+ height = s->height;
+ }
AMEDIAFORMAT_GET_INT32(s->display_width, "display-width", 0);
AMEDIAFORMAT_GET_INT32(s->display_height, "display-height", 0);