summaryrefslogtreecommitdiff
path: root/libavcodec/libx264.c
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2021-11-07 14:50:27 +0100
committerAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2021-11-09 15:42:27 +0100
commit6f1130be7880dc9e5e7c812f377dc3e480580704 (patch)
tree4effaf48902491e3936bdcb3880ede1ed3325a7a /libavcodec/libx264.c
parente5199eebb44fa5b63dcec06d38cab515eaa52b6c (diff)
avcodec/libx264: Check for overflow if necessary
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavcodec/libx264.c')
-rw-r--r--libavcodec/libx264.c14
1 files changed, 12 insertions, 2 deletions
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index 0766b4a950..8711c72131 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -138,13 +138,23 @@ static int encode_nals(AVCodecContext *ctx, AVPacket *pkt,
{
X264Context *x4 = ctx->priv_data;
uint8_t *p;
- int i, size = x4->sei_size, ret;
+ uint64_t size = x4->sei_size;
+ int i;
+ int ret;
if (!nnal)
return 0;
- for (i = 0; i < nnal; i++)
+ for (int i = 0; i < nnal; i++) {
size += nals[i].i_payload;
+ /* ff_get_encode_buffer() accepts an int64_t and
+ * so we need to make sure that no overflow happens before
+ * that. With 32bit ints this is automatically true. */
+#if INT_MAX > INT64_MAX / INT_MAX - 1
+ if ((int64_t)size < 0)
+ return AVERROR(ERANGE);
+#endif
+ }
if ((ret = ff_get_encode_buffer(ctx, pkt, size, 0)) < 0)
return ret;