summaryrefslogtreecommitdiff
path: root/libavcodec/libopusenc.c
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2023-03-13 05:08:53 +0100
committerAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2023-03-18 07:21:35 +0100
commitadb5f7b41faf354a3e0bf722f44aeb230aefa310 (patch)
treee26aec914a76bedef026f7bca5d9f7f61a4a1407 /libavcodec/libopusenc.c
parente5abcf0d290df85b78b9f52d52e824a7f1123d11 (diff)
avcodec/libopusenc: Remove redundant av_packet_unref()
The AVPacket given to an encoder's encode callback is unreferenced generically on error. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavcodec/libopusenc.c')
-rw-r--r--libavcodec/libopusenc.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/libavcodec/libopusenc.c b/libavcodec/libopusenc.c
index 75bc491c9e..5a0786f32f 100644
--- a/libavcodec/libopusenc.c
+++ b/libavcodec/libopusenc.c
@@ -512,18 +512,14 @@ static int libopus_encode(AVCodecContext *avctx, AVPacket *avpkt,
discard_padding = opus->opts.packet_size - avpkt->duration;
// Check if subtraction resulted in an overflow
- if ((discard_padding < opus->opts.packet_size) != (avpkt->duration > 0)) {
- av_packet_unref(avpkt);
+ if ((discard_padding < opus->opts.packet_size) != (avpkt->duration > 0))
return AVERROR(EINVAL);
- }
if (discard_padding > 0) {
uint8_t* side_data = av_packet_new_side_data(avpkt,
AV_PKT_DATA_SKIP_SAMPLES,
10);
- if(!side_data) {
- av_packet_unref(avpkt);
+ if (!side_data)
return AVERROR(ENOMEM);
- }
AV_WL32(side_data + 4, discard_padding);
}