diff options
author | Ronald S. Bultje <rsbultje@gmail.com> | 2017-04-04 12:45:51 -0400 |
---|---|---|
committer | Ronald S. Bultje <rsbultje@gmail.com> | 2017-04-06 10:03:28 -0400 |
commit | 32baeafeee4f8446c2c3720b9223ad2166ca9d30 (patch) | |
tree | b817e4d57ea80f33e1b4a9915462e4601d06bde6 /libavcodec/jrevdct.c | |
parent | e0c205677f6b3b7dba6891724cb68bfb81e9b8d6 (diff) |
jrev/xvid: hardcode use of C put/add_pixels_clamped.
This removes the last use of the ff_put/add_pixels_clamped global
function pointers, and as such they are removed.
This patch has a negative effect on performance on MIPS, since there's
a SIMD-optimized put/add_pixels_clamped, but no xvid or jrev. From a
code maintenance point of view, that is probably acceptable.
Because the global function pointers are removed, this fixes the following
tsan warnings when running e.g. fate-dnxhr-parse:
WARNING: ThreadSanitizer: data race (pid=29917)
Write of size 8 at 0x0000025b12d8 by thread T2 (mutexes: write M1543):
#0 ff_idctdsp_init src/libavcodec/idctdsp.c:313 (ffmpeg+0x00000044b68e)
[..]
Previous write of size 8 at 0x0000025b12d8 by thread T1 (mutexes: write M1541):
#0 ff_idctdsp_init src/libavcodec/idctdsp.c:313 (ffmpeg+0x00000044b68e)
Diffstat (limited to 'libavcodec/jrevdct.c')
-rw-r--r-- | libavcodec/jrevdct.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libavcodec/jrevdct.c b/libavcodec/jrevdct.c index 89dd9f2fca..3b15a52677 100644 --- a/libavcodec/jrevdct.c +++ b/libavcodec/jrevdct.c @@ -1159,11 +1159,11 @@ void ff_j_rev_dct1(DCTBLOCK data){ void ff_jref_idct_put(uint8_t *dest, ptrdiff_t line_size, int16_t *block) { ff_j_rev_dct(block); - ff_put_pixels_clamped(block, dest, line_size); + ff_put_pixels_clamped_c(block, dest, line_size); } void ff_jref_idct_add(uint8_t *dest, ptrdiff_t line_size, int16_t *block) { ff_j_rev_dct(block); - ff_add_pixels_clamped(block, dest, line_size); + ff_add_pixels_clamped_c(block, dest, line_size); } |