summaryrefslogtreecommitdiff
path: root/libavcodec/dcadec.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2015-05-15 18:29:40 +0200
committerMichael Niedermayer <michaelni@gmx.at>2015-05-15 18:29:40 +0200
commitfc624ec9ba7e5c4e8d905ac10f605a43d123f95a (patch)
treefc9c939b39783f764c495e5eed15ce4d3d0c3847 /libavcodec/dcadec.c
parent0f3e6959bfa67d12cd5a173b86eb15abd7d9e4d5 (diff)
avcodec/dcadec: Check active_bands
Fixes CID1297594 part2 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavcodec/dcadec.c')
-rw-r--r--libavcodec/dcadec.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c
index 25b426d864..91db893c56 100644
--- a/libavcodec/dcadec.c
+++ b/libavcodec/dcadec.c
@@ -1242,8 +1242,13 @@ int ff_dca_xbr_parse_frame(DCAContext *s)
for(i = 0; i < num_chsets; i++) {
n_xbr_ch[i] = get_bits(&s->gb, 3) + 1;
k = get_bits(&s->gb, 2) + 5;
- for(j = 0; j < n_xbr_ch[i]; j++)
+ for(j = 0; j < n_xbr_ch[i]; j++) {
active_bands[i][j] = get_bits(&s->gb, k) + 1;
+ if (active_bands[i][j] > DCA_SUBBANDS) {
+ av_log(s->avctx, AV_LOG_ERROR, "too many active subbands (%d)\n", active_bands[i][j]);
+ return AVERROR_INVALIDDATA;
+ }
+ }
}
/* skip to the end of the header */