summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorFelix LeClair <felix.leclair123@hotmail.com>2022-04-28 13:17:22 -0400
committerMarton Balint <cus@passwd.hu>2022-05-01 12:42:07 +0200
commit987d2c1083d9bc9464000c8732c3353c7bf7e9ca (patch)
tree54ac21fc48e5864eb984e1fe861216762d61122a /doc
parent296d3bbe167f06168ac54724626006b43002833f (diff)
avcodec/x86/hevc_mc: Fix AVX-512-VNNI_hevc_qpel_filters_avx512icl
Issue: On extremely new hardware using either IceLake or super sets of Intel IceLakes avx512 instructions, commit d4cd8830bdac3e26c8e75cd92e574c159fecc4f7 causes build issues. Specifically a NASM macro expansion of qpel_filter_v is never properly defined/initialized. The issue is the definition was erroneously placed inside a conditional which will not trigger unless the original definition failed (has to do with if PIC is defined, becomes a bit of a catch 22) Specifically the error is X86ASM libavcodec/x86/hevc_mc.o libavcodec/x86/hevc_mc.asm:1854: error: symbol `..@88472.table' not defined libavcodec/x86/hevc_mc.asm:1806: ... from macro `HEVC_PUT_HEVC_QPEL_HV_AVX512ICL' defined here libavcodec/x86/hevc_mc.asm:1730: ... from macro `QPEL_FILTER_V' defined here ... repeats a few times... ... make: *** [ffbuild/common.mak:100: libavcodec/x86/hevc_mc.o] Error 1 ``` Specific error was discussed by kurosu and myself (fclc) on the ffmpeg-devel irc. This commit fixes the above by swapping lines 1796 and 1795, moving the define out of the conditional Side note: It seems fate didn't pick up on this, may merit looking into (as mentioned by nevcairiel). Reviewed-by: Wu Jianhua <toqsxw@outlook.com> Signed-off-by: Felix LeClair (FCLC) <felix.leclair123@hotmail.com> Signed-off-by: Marton Balint <cus@passwd.hu>
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions