summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames Almer <jamrial@gmail.com>2022-07-29 18:05:51 -0300
committerJames Almer <jamrial@gmail.com>2022-07-30 09:21:19 -0300
commit6ca16906439f689e4627b7cb4e6466bd45cc696f (patch)
tree85818c81eaa2435e9d07b8b1f84937ed6f2fa773
parent6406d5e430953085a0100b44dd8fceb478b383e2 (diff)
avcodec/alac: don't fail if channels aren't set during init() when extradata is valid
The decoder is meant to use it as a fallback if the value in extradata is invalid. Regression since d199099be. Signed-off-by: James Almer <jamrial@gmail.com>
-rw-r--r--libavcodec/alac.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/libavcodec/alac.c b/libavcodec/alac.c
index b232514169..8b87d78dd3 100644
--- a/libavcodec/alac.c
+++ b/libavcodec/alac.c
@@ -574,13 +574,15 @@ static av_cold int alac_decode_init(AVCodecContext * avctx)
avctx->bits_per_raw_sample = alac->sample_size;
avctx->sample_rate = alac->sample_rate;
- if (alac->channels < 1 || alac->channels > ALAC_MAX_CHANNELS) {
+ if (alac->channels < 1) {
av_log(avctx, AV_LOG_WARNING, "Invalid channel count\n");
+ if (avctx->ch_layout.nb_channels < 1)
+ return AVERROR(EINVAL);
alac->channels = avctx->ch_layout.nb_channels;
}
- if (avctx->ch_layout.nb_channels > ALAC_MAX_CHANNELS || avctx->ch_layout.nb_channels <= 0 ) {
+ if (alac->channels > ALAC_MAX_CHANNELS) {
avpriv_report_missing_feature(avctx, "Channel count %d",
- avctx->ch_layout.nb_channels);
+ alac->channels);
return AVERROR_PATCHWELCOME;
}
av_channel_layout_uninit(&avctx->ch_layout);