diff options
| author | Steven Liu <lq@chinaffmpeg.org> | 2018-02-01 10:55:19 +0800 |
|---|---|---|
| committer | Steven Liu <lq@chinaffmpeg.org> | 2018-02-01 10:55:19 +0800 |
| commit | 27fe8930e0b9e7881e61eb9ed0b8b526f718abfe (patch) | |
| tree | 40f884591847595ed9c08d4536b7ff0077f32962 | |
| parent | 61a4ee8ab482925cb419133cab42e4c4ef6a3f07 (diff) | |
avfilter: add comments for duplicate line
comment about the looks like a duplicate line.
but that is used to reason x is expressed from y
Suggested-by: Paul B Mahol
Suggested-by: Michael Niedermayer
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
| -rw-r--r-- | libavfilter/vf_crop.c | 1 | ||||
| -rw-r--r-- | libavfilter/vf_drawtext.c | 1 | ||||
| -rw-r--r-- | libavfilter/vf_overlay.c | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 7c31c1665d..0fdc4949e3 100644 --- a/libavfilter/vf_crop.c +++ b/libavfilter/vf_crop.c @@ -262,6 +262,7 @@ static int filter_frame(AVFilterLink *link, AVFrame *frame) NAN : frame->pkt_pos; s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL); s->var_values[VAR_Y] = av_expr_eval(s->y_pexpr, s->var_values, NULL); + /* It is necessary if x is expressed from y */ s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL); normalize_double(&s->x, s->var_values[VAR_X]); diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index f97a741b50..e8905a40d3 100644 --- a/libavfilter/vf_drawtext.c +++ b/libavfilter/vf_drawtext.c @@ -1390,6 +1390,7 @@ static int draw_text(AVFilterContext *ctx, AVFrame *frame, s->x = s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, &s->prng); s->y = s->var_values[VAR_Y] = av_expr_eval(s->y_pexpr, s->var_values, &s->prng); + /* It is necessary if x is expressed from y */ s->x = s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, &s->prng); update_alpha(s); diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index aa5835ae3a..c6a6ac82f3 100644 --- a/libavfilter/vf_overlay.c +++ b/libavfilter/vf_overlay.c @@ -149,6 +149,7 @@ static void eval_expr(AVFilterContext *ctx) s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL); s->var_values[VAR_Y] = av_expr_eval(s->y_pexpr, s->var_values, NULL); + /* It is necessary if x is expressed from y */ s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL); s->x = normalize_xy(s->var_values[VAR_X], s->hsub); s->y = normalize_xy(s->var_values[VAR_Y], s->vsub); |