summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2017-08-17 18:24:37 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2017-08-20 02:59:57 +0200
commit0c9d5b015c2022e8deebb93367f8ee8a8eb779e8 (patch)
tree2f1d1c07899f9c46a9b1747c49d018bf5491b5fc
parentd132683ddd4050d3fe103ca88c73258c3442dc34 (diff)
avcodec/fic: Fixes signed integer overflow
Fixes: runtime error: signed integer overflow: 1037142357 + 1227025305 cannot be represented in type 'int' Fixes: 3024/clusterfuzz-testcase-minimized-5885660323905536 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/fic.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/libavcodec/fic.c b/libavcodec/fic.c
index 46260ee281..d7ee370423 100644
--- a/libavcodec/fic.c
+++ b/libavcodec/fic.c
@@ -85,12 +85,12 @@ static const uint8_t fic_header[7] = { 0, 0, 1, 'F', 'I', 'C', 'V' };
static av_always_inline void fic_idct(int16_t *blk, int step, int shift, int rnd)
{
- const int t0 = 27246 * blk[3 * step] + 18405 * blk[5 * step];
- const int t1 = 27246 * blk[5 * step] - 18405 * blk[3 * step];
- const int t2 = 6393 * blk[7 * step] + 32139 * blk[1 * step];
- const int t3 = 6393 * blk[1 * step] - 32139 * blk[7 * step];
- const unsigned t4 = 5793U * (t2 + t0 + 0x800 >> 12);
- const unsigned t5 = 5793U * (t3 + t1 + 0x800 >> 12);
+ const unsigned t0 = 27246 * blk[3 * step] + 18405 * blk[5 * step];
+ const unsigned t1 = 27246 * blk[5 * step] - 18405 * blk[3 * step];
+ const unsigned t2 = 6393 * blk[7 * step] + 32139 * blk[1 * step];
+ const unsigned t3 = 6393 * blk[1 * step] - 32139 * blk[7 * step];
+ const unsigned t4 = 5793U * ((int)(t2 + t0 + 0x800) >> 12);
+ const unsigned t5 = 5793U * ((int)(t3 + t1 + 0x800) >> 12);
const unsigned t6 = t2 - t0;
const unsigned t7 = t3 - t1;
const unsigned t8 = 17734 * blk[2 * step] - 42813 * blk[6 * step];