diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2021-04-25 20:45:10 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2021-06-18 18:58:25 +0200 |
| commit | fe12aa689003db9b07a6e1b837031dcc57a71435 (patch) | |
| tree | 04930acc2c35970fbe12a2c87d0fac154454c1c5 | |
| parent | 1b865cc703d29cb307e1fa628aa02940d54eb42a (diff) | |
avformat/realtextdec: Check the pts difference before using it for the duration computation
Fixes: signed integer overflow: 5404200000 - -9223372031709351616 cannot be represented in type 'long'
Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_REALTEXT_fuzzer-6737340551790592
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavformat/realtextdec.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libavformat/realtextdec.c b/libavformat/realtextdec.c index 22fc58bc99..3aeeee8d1c 100644 --- a/libavformat/realtextdec.c +++ b/libavformat/realtextdec.c @@ -111,10 +111,11 @@ static int realtext_read_header(AVFormatContext *s) if (!merge) { const char *begin = ff_smil_get_attr_ptr(buf.str, "begin"); const char *end = ff_smil_get_attr_ptr(buf.str, "end"); + int64_t endi = end ? read_ts(end) : 0; sub->pos = pos; sub->pts = begin ? read_ts(begin) : 0; - sub->duration = end ? (read_ts(end) - sub->pts) : duration; + sub->duration = (end && endi > sub->pts && endi - (uint64_t)sub->pts <= INT64_MAX) ? endi - sub->pts : duration; } } av_bprint_clear(&buf); |