summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnton Khirnov <anton@khirnov.net>2022-11-27 10:47:53 +0100
committerAnton Khirnov <anton@khirnov.net>2022-11-28 10:34:10 +0100
commite68fff64ca2fb3752d027fb3ec8bcd1d216036f0 (patch)
treea9c877f4c7aefd436505586a49ebebef6889d613
parent64e8d13a572b139efadb16edb963ceff66b3d619 (diff)
lavc/libx264: reorder control flow in setup_roi() to reduce nesting depth
-rw-r--r--libavcodec/libx264.c28
1 files changed, 14 insertions, 14 deletions
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index f0f8990cf9..342d07a829 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -338,13 +338,6 @@ static int setup_roi(AVCodecContext *ctx, x264_picture_t *pic, int bit_depth,
{
X264Context *x4 = ctx->priv_data;
- if (x4->params.rc.i_aq_mode == X264_AQ_NONE) {
- if (!x4->roi_warned) {
- x4->roi_warned = 1;
- av_log(ctx, AV_LOG_WARNING, "Adaptive quantization must be enabled to use ROI encoding, skipping ROI.\n");
- }
- } else {
- if (frame->interlaced_frame == 0) {
int mbx = (frame->width + MB_SIZE - 1) / MB_SIZE;
int mby = (frame->height + MB_SIZE - 1) / MB_SIZE;
int qp_range = 51 + 6 * (bit_depth - 8);
@@ -353,6 +346,20 @@ static int setup_roi(AVCodecContext *ctx, x264_picture_t *pic, int bit_depth,
uint32_t roi_size;
float *qoffsets;
+ if (x4->params.rc.i_aq_mode == X264_AQ_NONE) {
+ if (!x4->roi_warned) {
+ x4->roi_warned = 1;
+ av_log(ctx, AV_LOG_WARNING, "Adaptive quantization must be enabled to use ROI encoding, skipping ROI.\n");
+ }
+ return 0;
+ } else if (frame->interlaced_frame) {
+ if (!x4->roi_warned) {
+ x4->roi_warned = 1;
+ av_log(ctx, AV_LOG_WARNING, "interlaced_frame not supported for ROI encoding yet, skipping ROI.\n");
+ }
+ return 0;
+ }
+
roi = (const AVRegionOfInterest*)data;
roi_size = roi->self_size;
if (!roi_size || size % roi_size != 0) {
@@ -395,13 +402,6 @@ static int setup_roi(AVCodecContext *ctx, x264_picture_t *pic, int bit_depth,
pic->prop.quant_offsets = qoffsets;
pic->prop.quant_offsets_free = av_free;
- } else {
- if (!x4->roi_warned) {
- x4->roi_warned = 1;
- av_log(ctx, AV_LOG_WARNING, "interlaced_frame not supported for ROI encoding yet, skipping ROI.\n");
- }
- }
- }
return 0;
}