summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnton Khirnov <anton@khirnov.net>2022-07-12 11:25:09 +0200
committerAnton Khirnov <anton@khirnov.net>2022-11-28 10:34:10 +0100
commit4debad6b5ffa8c9079e6c5b7aadcc61fbf22bd8f (patch)
treed3a76a766b050dbf1f72a5b4c6ee18ed270ec8e3
parente58bb62921d0d1344531b53677a6b70a1184ba36 (diff)
lavc/librav1e: handle frame durations and AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE
-rw-r--r--libavcodec/librav1e.c61
1 files changed, 53 insertions, 8 deletions
diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
index 4f424caf5b..669bfd5428 100644
--- a/libavcodec/librav1e.c
+++ b/libavcodec/librav1e.c
@@ -22,6 +22,7 @@
#include <rav1e.h>
+#include "libavutil/buffer.h"
#include "libavutil/internal.h"
#include "libavutil/avassert.h"
#include "libavutil/base64.h"
@@ -53,6 +54,15 @@ typedef struct librav1eContext {
int tile_cols;
} librav1eContext;
+typedef struct FrameData {
+ int64_t pts;
+ int64_t duration;
+ int64_t reordered_opaque;
+
+ void *frame_opaque;
+ AVBufferRef *frame_opaque_ref;
+} FrameData;
+
static inline RaPixelRange range_map(enum AVPixelFormat pix_fmt, enum AVColorRange range)
{
switch (pix_fmt) {
@@ -420,11 +430,23 @@ end:
return ret;
}
+static void frame_data_free(void *data)
+{
+ FrameData *fd = data;
+
+ if (!fd)
+ return;
+
+ av_buffer_unref(&fd->frame_opaque_ref);
+ av_free(data);
+}
+
static int librav1e_receive_packet(AVCodecContext *avctx, AVPacket *pkt)
{
librav1eContext *ctx = avctx->priv_data;
RaFrame *rframe = ctx->rframe;
RaPacket *rpkt = NULL;
+ FrameData *fd;
int ret;
if (!rframe) {
@@ -437,18 +459,30 @@ static int librav1e_receive_packet(AVCodecContext *avctx, AVPacket *pkt)
if (frame->buf[0]) {
const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(frame->format);
- int64_t *pts = av_malloc(sizeof(int64_t));
- if (!pts) {
+ fd = av_mallocz(sizeof(*fd));
+ if (!fd) {
av_log(avctx, AV_LOG_ERROR, "Could not allocate PTS buffer.\n");
return AVERROR(ENOMEM);
}
- *pts = frame->pts;
+ fd->pts = frame->pts;
+ fd->duration = frame->duration;
+ fd->reordered_opaque = frame->reordered_opaque;
+
+ fd->frame_opaque = frame->opaque;
+ if (frame->opaque_ref && avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) {
+ fd->frame_opaque_ref = av_buffer_ref(frame->opaque_ref);
+ if (!fd->frame_opaque_ref) {
+ frame_data_free(fd);
+ av_frame_unref(frame);
+ return AVERROR(ENOMEM);
+ }
+ }
rframe = rav1e_frame_new(ctx->ctx);
if (!rframe) {
av_log(avctx, AV_LOG_ERROR, "Could not allocate new rav1e frame.\n");
av_frame_unref(frame);
- av_freep(&pts);
+ frame_data_free(fd);
return AVERROR(ENOMEM);
}
@@ -460,7 +494,7 @@ static int librav1e_receive_packet(AVCodecContext *avctx, AVPacket *pkt)
frame->linesize[i], bytes);
}
av_frame_unref(frame);
- rav1e_frame_set_opaque(rframe, pts, av_free);
+ rav1e_frame_set_opaque(rframe, fd, frame_data_free);
}
}
@@ -536,8 +570,18 @@ retry:
if (rpkt->frame_type == RA_FRAME_TYPE_KEY)
pkt->flags |= AV_PKT_FLAG_KEY;
- pkt->pts = pkt->dts = *((int64_t *) rpkt->opaque);
- av_free(rpkt->opaque);
+ fd = rpkt->opaque;
+ pkt->pts = pkt->dts = fd->pts;
+ pkt->duration = fd->duration;
+ avctx->reordered_opaque = fd->reordered_opaque;
+
+ if (avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) {
+ pkt->opaque = fd->frame_opaque;
+ pkt->opaque_ref = fd->frame_opaque_ref;
+ fd->frame_opaque_ref = NULL;
+ }
+
+ frame_data_free(fd);
if (avctx->flags & AV_CODEC_FLAG_RECON_FRAME) {
AVCodecInternal *avci = avctx->internal;
@@ -627,7 +671,8 @@ const FFCodec ff_librav1e_encoder = {
.defaults = librav1e_defaults,
.p.pix_fmts = librav1e_pix_fmts,
.p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_OTHER_THREADS |
- AV_CODEC_CAP_DR1 | AV_CODEC_CAP_ENCODER_RECON_FRAME,
+ AV_CODEC_CAP_DR1 | AV_CODEC_CAP_ENCODER_RECON_FRAME |
+ AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE,
.caps_internal = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_AUTO_THREADS,
.p.wrapper_name = "librav1e",