diff options
author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2022-08-15 10:18:22 +0200 |
---|---|---|
committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2022-08-18 16:57:47 +0200 |
commit | f76cef5c518a9874ec4e3b4b36c5b909c3452919 (patch) | |
tree | 8a884c9d47d5d250be1218863b53b7883c422cea | |
parent | e50684318390b5cffc68da131f7630f11814b808 (diff) |
avcodec/get_buffer: Don't get AVPixFmtDescriptor unnecessarily
It is unused since 3575a495f6dcc395656343380e13c57d48b9f976
(and the error message is dangerous: av_get_pix_fmt_name(format)
returns NULL iff av_pix_fmt_desc_get(format) returns NULL
and using a NULL string for %s would be UB).
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
-rw-r--r-- | libavcodec/get_buffer.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/libavcodec/get_buffer.c b/libavcodec/get_buffer.c index 3e45a0479f..a04fd878de 100644 --- a/libavcodec/get_buffer.c +++ b/libavcodec/get_buffer.c @@ -246,7 +246,6 @@ fail: static int video_get_buffer(AVCodecContext *s, AVFrame *pic) { FramePool *pool = (FramePool*)s->internal->pool->data; - const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(pic->format); int i; if (pic->data[0] || pic->data[1] || pic->data[2] || pic->data[3]) { @@ -254,13 +253,6 @@ static int video_get_buffer(AVCodecContext *s, AVFrame *pic) return -1; } - if (!desc) { - av_log(s, AV_LOG_ERROR, - "Unable to get pixel format descriptor for format %s\n", - av_get_pix_fmt_name(pic->format)); - return AVERROR(EINVAL); - } - memset(pic->data, 0, sizeof(pic->data)); pic->extended_data = pic->data; |