diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2022-08-12 00:27:41 +0200 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2022-08-12 19:37:06 +0200 |
| commit | c1b966a189f3ffef8bd48d744e644f573a218608 (patch) | |
| tree | 4f87d967d7efdd8d762ebfa9b2186643ebf38a57 | |
| parent | d5b46fa07d946ce3ef872636338b0f4252f21424 (diff) | |
avcodec/mimic: Fix undefined pointer arithmetic
NULL + anything is UB.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
| -rw-r--r-- | libavcodec/mimic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libavcodec/mimic.c b/libavcodec/mimic.c index ce5c2afd19..bcf10b7ae1 100644 --- a/libavcodec/mimic.c +++ b/libavcodec/mimic.c @@ -268,8 +268,9 @@ static int decode(MimicContext *ctx, int quality, int num_coeffs, const int qscale = av_clip(10000 - quality, is_chroma ? 1000 : 2000, 10000) << 2; const int stride = ctx->frames[ctx->cur_index ].f->linesize[plane]; - const uint8_t *src = ctx->frames[ctx->prev_index].f->data[plane]; uint8_t *dst = ctx->frames[ctx->cur_index ].f->data[plane]; + /* src is unused for I frames; set to avoid UB pointer arithmetic. */ + const uint8_t *src = is_iframe ? dst : ctx->frames[ctx->prev_index].f->data[plane]; for (y = 0; y < ctx->num_vblocks[plane]; y++) { for (x = 0; x < ctx->num_hblocks[plane]; x++) { |