summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Use two dashes instead of a single dash when describing command lineschnetter2006-06-23
| | | | | | | | | | | | | option. This is now the preferred format, as per the recent discussion on the developers' mailing list. Comment out a leftover non-commented part of the non-exising "x" option. Reformat the command line descriptions slightly. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4330 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Add a new command line option to select the buffering mode of stdout.schnetter2006-06-23
| | | | | | | | | | | | | The option is "-b <mode>", or "-buffering=<mode>", where mode can be "no", "line", or "full". This option uses the ANSI C function call setvbuf() to select the corresponding buffering mode. The buffering mode can be selected only once in a portable programme, and it has to be selected before the first output occurs. This means that it has to be implemented in the flesh. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4329 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Application of Frank Löffler's patch of 28.02.06swhite2006-06-15
| | | | | | | | | | | | | reduces FARGUMENTS line length in cctk.h http://www.cactuscode.org/old/pipermail/patches/2006-February/000138.html "Spaces in _CCTK_FARGUMENTS removed to use as less space as possible. This leaves thorn writers more space for their own variables. Space can be a problem because of Fortran standard and/or compiler limitations." git-svn-id: http://svn.cactuscode.org/flesh/trunk@4322 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Application of patchswhite2006-06-08
| | | | | | | | | | | | | | | | WarnLevel bold off unless output is to tty http://www.cactuscode.org/old/pipermail/patches/2006-April/000161.html I got tired of seeing all the terminal control characters in Cactus output that was piped to files. Tested by watching Cactus output on a terminal, then piping ouput from the same program to a file. E.g. in bash make config-testsuite 2>&1 |tee > ts git-svn-id: http://svn.cactuscode.org/flesh/trunk@4316 17b73243-c579-4c4c-a9d2-2d5706c11dac
* apply patchjthorn2006-06-01
| | | | | | | | | | | | http://www.cactuscode.org/old/pipermail/patches/2006-May/000180.html This documents the 5 (!) separate places in the code which must be changed to add a new command-line option. See also the discussion in http://www.cactuscode.org/mailman/private/cactusmaint/2006-May/021429.html http://www.cactuscode.org/mailman/private/cactusmaint/2006-May/021430.html git-svn-id: http://svn.cactuscode.org/flesh/trunk@4310 17b73243-c579-4c4c-a9d2-2d5706c11dac
* slightly clarify wording in GRDOC comments forjthorn2006-05-14
| | | | | | | | | | | CCTK_GroupTagsTable() CCTK_GroupTagsTableI() (this change is *only* to comment wording -- there's no change to executable code) git-svn-id: http://svn.cactuscode.org/flesh/trunk@4298 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Applies Erik's patch from 06.03.06swhite2006-05-11
| | | | | | | Define HAVE_CCTK_BYTE etc. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4294 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Applying Erik's patch from 6.10.05swhite2006-05-11
| | | | | | | New command line option to stop after printing the schedule git-svn-id: http://svn.cactuscode.org/flesh/trunk@4293 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Fix return code of CCTK_CreateDirectory() if it already exists.tradke2006-05-08
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4292 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Fix a bug in CCTK_ParameterSet() .jthorn2006-04-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The symptoms were that if you (a) set the same parameter twice, *and* (b) the second setting is an invalid value, then current-CVS Cactus core-dumps inside the flesh trying to free() a garbage (uninitialized) pointer. For example, the following par file suffices to trigger the core-dump, using only flesh parameters (*no* thorns activated): # this par file causes a core dump in current-CVS Cactus Cactus::cctk_timer_output = "off" Cactus::cctk_timer_output = "foo" # an illegal value for this parameter Looking at the code, 599 /* check if a parameter is set more than once in a parfile */ 600 if (cctk_parameter_set_mask == PARAMETER_RECOVERY_PRE && 601 param->props->n_set > 0) 602 { 603 if (retval == 0) 604 { 605 new_value = CCTK_ParameterValString (param->props->name, 606 param->props->thorn); 607 retval = strcmp (old_value, new_value) ? -10 : -11; 608 } 609 free (new_value); 610 } Notice that the free() at line 609 may be executed even if new_value was *not* assigned a value at line 605. Alas, new_value is a local variable in this function, and is not explicitly initialized, so it has a garbage value initially... and line 605 is its only assignment in this function. The fix is easy -- just move the free() up to right after line 607, so it's executed if and only if new_value has been assigned. patch was http://www.cactuscode.org/old/pipermail/patches/2006-April/000162.html developers discussion was http://www.cactuscode.org/old/pipermail/developers/2006-April/001758.html http://www.cactuscode.org/old/pipermail/developers/2006-April/001759.html git-svn-id: http://svn.cactuscode.org/flesh/trunk@4285 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Correct 3D stagger codesschnetter2006-04-20
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4284 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Correct typographical error in warning messageschnetter2006-03-21
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4272 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Completed the previous fix -- I had missed another occurrance of theswhite2006-03-08
| | | | | | | types in question. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4267 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Fix for bug introduced by recent patch in systems with non-SYSV conformantswhite2006-03-07
| | | | | | | | | | | | | | | | | | | | | | | sys/time.h, such as Darwin 7.9.0. The SYSV declaration is struct timeval { time_t tv_sec; /* seconds */ suseconds_t tv_usec; /* and microsecond }; I had used time_t and suseconds_t thinking they were the safe types to use, but older BSD systems use longs for both. SYSV only specifies that they be signed integral types, suseconds_t must hold 1,000,000 and -1, so long should be enough for both. See http://www.opengroup.org/onlinepubs/007908799/xsh/systime.h.html http://www.opengroup.org/onlinepubs/007908799/xsh/systypes.h.html git-svn-id: http://svn.cactuscode.org/flesh/trunk@4266 17b73243-c579-4c4c-a9d2-2d5706c11dac
* As discussed in today's Cactus call, applying a patch from Feb 13swhite2006-03-02
| | | | | | | Patches mailing list. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4264 17b73243-c579-4c4c-a9d2-2d5706c11dac
* As discussed in today's Cactus call, applying patches from 14 Febswhite2006-03-02
| | | | | | | Patches mailing list. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4263 17b73243-c579-4c4c-a9d2-2d5706c11dac
* As discussed in today's Cactus call, applying a couple of the patchesswhite2006-03-02
| | | | | | | | | | from 14 Feb Patches list. As discussed, will further investigate the validity and origin of the Complex sqrt function later. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4262 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Also print the working directory in the banner output at startup.tradke2006-02-16
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4256 17b73243-c579-4c4c-a9d2-2d5706c11dac
* See Cactus Patches <patches@cactuscode.org>swhite2006-02-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Subject: CactusDefaultEvolve.c cleanup Date: Fri, 23 Dec 2005 15:43:50 +0100 The code in CactusDefaultEvolve.c, was complicated by 1) a global variable, cactus_terminate, which is checked but never set except in commented-out code, and 2) a lot of other commented-out code. This patch only removes code that is never used, and is intended to make the remaining code easier to follow and potentially safer. I checked all arrangements available to me, including Carpet, for cactus_terminate. It appears only in CactusPUGH/PUGH/src/Evolve.c (where it is commented out) AlphaThorns/Spawner/src/Evolve.c This change removes * live but useless code that references cactus_terminate * commented-out TerminationStepper function * commented-out code for cactus_terminate_global * now-unused TERMINATION_RAISED_BRDCAST * numerous commented out CCTK*Timer code I checked to see that it compiles, and is a patch against the most recent checkout. I then ran the standard testsuites with the modified code and verified that their results were identical to those with the unmodified code. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4253 17b73243-c579-4c4c-a9d2-2d5706c11dac
* According to the standard, the ptrdiff_t type is declared in <stddef.h> (andtradke2006-02-09
| | | | | | | not in <stdlib.h> as used in my previous commit). git-svn-id: http://svn.cactuscode.org/flesh/trunk@4251 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Define the variable cctki_dummy_int (which is used internally in thetradke2006-02-08
| | | | | | | | | | DECLARE_CCTK_ARGUMENTS macro to do pointer arithmetics) of type 'ptrdiff_t' rather than 'int'. This prevents compiler warnings on 64-bit systems where pointer offsets are assumed as long ints. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4250 17b73243-c579-4c4c-a9d2-2d5706c11dac
* When recovering parameters from checkpoint, only warn about attempts to settradke2006-02-03
| | | | | | | | | | a non-steerable parameter if its value in the recovery parfile differs from the one in the checkpoint. This avoids unnecessary warnings when recovering with the same parfile (and IO::recovery = "autoprobe" set). git-svn-id: http://svn.cactuscode.org/flesh/trunk@4249 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Fix for the erroneuously lablelled memory corruption. It seems what was just ↵yye002006-01-10
| | | | | | needed was more checking. This checked out alright on lemieux. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4231 17b73243-c579-4c4c-a9d2-2d5706c11dac
* minor fix for complex numbersyye002006-01-06
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4230 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Fix macro for getting size of staggered array.goodale2005-12-15
| | | | | | | Patch from David Rideout. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4215 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Extend CCTK_VWarn() so that, if Cactus::cctk_full_warnings is set to true,tradke2005-12-13
| | | | | | | | | it also prints the hostname of the originating warning message. This information comes in handy when debugging a problem on clusters by directly logging into the nodes. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4214 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Patch from Erik Schnetter to track the capacity of the list andgoodale2005-12-13
| | | | | | | produce an error if it is exceeded. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4210 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Define macros CCTK_{INT,REAL,COMPLEX}_PRECISION to values of 1, 2, 4, 8, 16,goodale2005-12-13
| | | | | | | | | | | or 32, depending on the definition of the default data types CCTK_{INT,REAL,COMPLEX}. These new macros make type generic code more convenient to write. Patch from Erik Schnetter. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4209 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Cosmetic changes.goodale2005-12-13
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4208 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Removing unused variables as found by David Rideout and Erik Schnetter.goodale2005-12-13
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4207 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Correcting some formatting.goodale2005-12-13
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4206 17b73243-c579-4c4c-a9d2-2d5706c11dac
* bumped the warning level from 3 to 1 on missing reduction operators (now ↵yye002005-12-12
| | | | | | that they are going mainstream). Fixed fortran interface to reduce local arrays, and a few minor cosmetic changes git-svn-id: http://svn.cactuscode.org/flesh/trunk@4204 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Correct typos in comments.schnetter2005-11-19
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4197 17b73243-c579-4c4c-a9d2-2d5706c11dac
* migration from misnomer pointwise-reduction to reduce arrays globallyyye002005-11-14
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4195 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Pointwise reduction flesh supportyye002005-11-08
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4194 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Make parameter array assignments without specifying the actual indextradke2005-11-03
| | | | | | | a major error also at the default parameter checking level. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4190 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Apply patch ↵tradke2005-10-24
| | | | | | | | | | | | | | | | | | | | | http://www.cactuscode.org/old/pipermail/patches/2005-October/000112.html: Check if there is more than one assignment to a parameter in the parfile and will print a warning with line number information in such a case. It checks both for multiple parameter assignments of the same or a different value. Depending on the parameter checking level (as set via the command line option '-parameter-level {strict|normal|relaxed}') the flesh will also abort the run after printing the warning in the following two cases: * the parameter level is "normal" (which is the default) or "strict" and there are multiple assignments of different values * the parameter level is "strict" and there are multiple assignments of the same value git-svn-id: http://svn.cactuscode.org/flesh/trunk@4188 17b73243-c579-4c4c-a9d2-2d5706c11dac
* A fix to routine documentation, more of these will be made as time allows ↵yye002005-10-21
| | | | | | (stumbled on it during reduction code review). git-svn-id: http://svn.cactuscode.org/flesh/trunk@4186 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Untabifying.goodale2005-10-03
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4163 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Renaming min macro to MIN to avoid a conflict on windows.goodale2005-10-03
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4162 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Adding missing header.goodale2005-10-03
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4161 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Changing C++ comment markers to C comment markers.goodale2005-10-03
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4160 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Do sanity checking on parameter file name and give a reason why itgoodale2005-10-03
| | | | | | | | can't be opened if at all possible. Fixes PR 1864. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4159 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Untabifying.goodale2005-10-03
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4158 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Patch from Jian Tao to add some callback functionality to thegoodale2005-10-03
| | | | | | | | | | warning system. This allows thorns to register functions which will be called when CCTK_Warn or CCTK_Info are called, with the contents of the warning/info message, thus allowing thorns to do things like logging warnings to file or displaying on webpages. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4157 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Undo changes that prevent more unwanted warnings about unused variables.schnetter2005-09-28
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4155 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Remove unused function declarations.schnetter2005-09-26
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4151 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Print run time warnings while setting parameters with CCTK_WARNschnetter2005-09-26
| | | | | | | | | | | | | | instead of with fprintf (stderr, ...). Correct critical error in looking at the values of cctk_full_warnings, highlight_warning_messages, and cctk_strong_param_check. Handle the empty regular expression specially in CCTK_RegexMatch, since regcomp may treat it as illegal expression. In Cactus, an empty regular expression matches everything. git-svn-id: http://svn.cactuscode.org/flesh/trunk@4150 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Introduce macros CCTK_DECLARE and CCTK_DECLARE_INIT which declare orschnetter2005-09-26
| | | | | | | | | | | | | | declare and initialise local variables. They also add the necessary magic to prevent compiler warnings about unused variables. If the compiler supports __attribute__((unused)), then use this. Otherwise, use the existing fallback of taking the variable's address. In Fortran, use the variable's kind as fallback. Use these macros in autogenerated code and in "cctk.h". git-svn-id: http://svn.cactuscode.org/flesh/trunk@4146 17b73243-c579-4c4c-a9d2-2d5706c11dac
* Correct typos in commentsschnetter2005-09-25
| | | | git-svn-id: http://svn.cactuscode.org/flesh/trunk@4142 17b73243-c579-4c4c-a9d2-2d5706c11dac
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-10 10:36:54 +0000