| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
distribution type of grid functions
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4465 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
number.
Ensure that the default values for keywords are checked as well,
currently in the same way as strings.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4456 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4455 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4453 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
is not needed.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4450 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4449 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
the EXTENDS or USES keywords.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4448 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4447 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4430 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4417 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turned out that most of the runtime of the parameter parser was spent
in flattening list/hash arguments during function calls. Using
references conveniently solves this performance bottleneck; for the
'PublicThorns' configuration used in the nightly integration tests (with
a list of some 120 thorns), the overall CST runtime went from 100s down to 8s.
This applies patch http://www.cactuscode.org/old/pipermail/patches/2007-February/000218.html
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4406 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
- Print all file names beginning at the same column, followed by a
colon
- Be consistent about inserting empty lines
- Ensure that a final newline character is added
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4405 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a testsuite:
* report the total number of such missing files
* don't list them anymore in the interactive file comparison mode
This fixes http://www.cactuscode.org/old/pipermail/developers/2007-January/005249.html.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4404 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- replace the excessive use of perl hash arrays to store ordinary perl array
information about absolute/relative differences found in a file comparison;
store a reference to that array instead and use it later in the testsuite
report output; this should speed up the comparison runtime by an order of
magnitude
- really output all absolute/relative differences found in a file comparison
(this was missing for files with special characters ('[',']') in their names
because the filename was used unprotected as a hash key)
- properly sort listing of absolute/relative differences
by column number in a datafile
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4402 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
required to run a testsuite in a thorn's test.ccl configuration file.
This closes PR 2078/Cactus: "specify the number of processors required to run a
testsuite".
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4401 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4398 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PREREGRIDINITIAL
POSTREGRIDINITIAL
POSTRESTRICTINITIAL
These bins are necessary so that thorns can distinguish between the
corresponding operations during evolution and during initial data
setup. That is, for example, operations that need to be performed
after restricting during time evolution may differ from operations
that need to be performed after restricting while initial data are set
up.
This closes PR/2074.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4393 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
| |
and working auto-generated tables describing parameters, etc.
Fixes PR2071.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4392 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(run nightly as non-interactive cron jobs):
1) Via shell environment variables 'CCTK_TESTSUITE_RUN_PROCESSORS' and
'CCTK_TESTSUITE_RUN_COMMAND', the user can override the default number
of processors to use, and the default run command.
2) When running the testsuite scripts, the user is now prompted with a template
for the command to be executed: now an arbitrary command line can be specified
with the number of processors, the executable, and the name of the parameter
file as template parameters.
3) A summary.log file is created in TEST/<configuration>/ subdir containing
the run details of a given configuration and a summary on the number of tests
of tests available/run/passed/failed. This information is the same as printed
to stdout and can be parsed appropriately by an automatic integration test
script.
4) For each testsuite that was run, a <testsuite>.diffs file containing the
differences detected while comparing output files. This information is the
same as printed to stdout and can be parsed appropriately by an automatic
integration test script.
This closes PR Cactus/2072: "enhance testsuite scripts to be used within
automatic Cactus integration tests".
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4391 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4390 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fri 20 Oct 06
"g++ warning: operation on *bla* may be undefined"
and PR 2070
http://www.cactuscode.org/cactus_cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&data
base=cactus&pr=2070
Preprocessing arrangements/Carpet/Carpet/src/Timing.cc
Compiling arrangements/Carpet/Carpet/src/Timing.cc
configs/chain_gcc_carpet/build/Carpet/Timing.cc:
In function ‘void Carpet::InitTimingVariables(const cGH*)’:
configs/chain_gcc_carpet/build/Carpet/Timing.cc:120:
warning: operation on ‘cctki_use’ may be undefined
The culprit was in generated bindings code meant to get rid of warnings
about unused variables corresponding to Cactus parameters included in
code by the DECLARE_CCTK_PARAMETERS macro.
This replaces the offending code with enums initialised by sizeof calls;
the nature of all the entities involved is much clearer, both to
compilers and to me.
Like the existing solution, this permits the user to proceed to make more
declarations after the DECLARE_CCTK_PARAMETERS macro (simply putting a list
of variable assignments after the declaration would not have that property).
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4381 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4378 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CCTK_FPOINTER callback argument which itself takes a CCTK_STRING argument.
This CCTK_STRING argument used to be passed by reference but should be passed
by value.
Example:
interface.ccl:
CCTK_INT FUNCTION Foo (CCTK_INT CCTK_FPOINTER IN Bar (CCTK_STRING IN s))
PROVIDES FUNCTION Foo WITH MyFoo LANGUAGE C
generated C bindings for invocation of callback:
static CCTK_INT (*CCTK_FptrMyFooBar) (CCTK_STRING s);
static CCTK_INT CCTK_WrapMyFooBar (CCTK_STRING s);
CCTK_INT CCTK_WrapMyFooBar (CCTK_STRING s)
{
return (*CCTK_FptrMyFooBar) (&s); /* before applying this patch WRONG */
return (*CCTK_FptrMyFooBar) (s); /* after applying this patch */
}
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4369 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4345 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
| |
Set the current file name together with the current line number when a
"#" statement is encountered.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4344 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
| |
include path and all files in such a directory. When a matching file
is found, exit all loops, not just the innermost one.
Use the same mechanism that was already used for "use" statements also
for "include" statements. Fortran include statements did not work
correctly before.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4343 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
which checks for mixed-dimensional GFs.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4339 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
included file is actually found. The previous code required that each
included file be in the same directory as the including file. The new
code treats using modules and including files in the same manner.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4328 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GridFuncStuff bug fix and cleanup
http://www.cactuscode.org/old/pipermail/patches/2006-May/000165.html
It fixes two minor bugs (that is, bugs that weren't bugging anybody right
now). It also includes an overall cleanup of the code, which begain with
the first bug fix, and resulted in the discovery of the second bug.
The first bug fix was to put in
use strict;
(According to L. Wall, a Perl file without use strict constitutes a bug.)
This resulted in lots of errors about variables needing their scope to be
specified. So I did this.
At the end, I found that I couldn't fix a certain occurrance of $group.
There was no sensible way that it was being set. The code was to produce
a warning concerning creating groups with mixed dimensions. See
'warn_mixeddim_gfs'.
The Perl code was taking a global value of $group set at build time to be
the last group in a loop. However, the offending group is determined at
run time in CreateThornGroupInitializers. So the warning message would
typically be wrong.
Affect code written in
bindings/Variables/<thorn>.c
Also: Perl 5-ied function calls
deleted great wads of commented-out code
Testing
-------
Ran testsuites on my laptop with Whisky benchmark thornlist.
No change was detected in the results.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4315 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4299 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4273 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
The language must be either 'C' or 'Fortran', allow for case-independence.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4265 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#define M2(a,b)
warn about the uses M2(x,) or M2(,y) or M2(,).
The empty arguments are still handled correctly. These warnings are only to
make it easier to port to systems where the system cpp does not handle empty
arguments and where one does not want to use the perl cpp instead.
Patch from Erik Schnetter.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4213 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
convert the macro value to either 0 or 1 before returning it.
Otherwise things fail badly if the macro is defined but empty: The
returned value is then not an integer, and cpp.pl would keep both the
#if and the #else branch of an if statement.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4205 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
testsuites.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4203 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
| |
capabilities. This prevents name clashes with e.g. system header
files.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4201 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
(e.g. if a thorn's configuration.ccl has changed).
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4200 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configuration bindings.
When reading the configuration settings from the output of the
configuration scripts (that provide capabilities), new lines were lost
in certain circumstances. This lead to makefile fragments like
PETSC_DIR = /usr/local/apps/petscPETSC_ARCH = linux
which are obviously incorrect (since these should be two lines, not
one), although this does not lead to errors or warnings.
This patch makes sure that all configuration settings have newline
characters appended or blanks prepended as they are concatenated into
the internal database (ConfigScriptParser.pl). When the database is
read out, the strings can just be printed to the file
(CreateConfigurationBindings.pl).
While doing this, this patch also removes some superfluous blanks and
newline characters from the output of the configuration settings.
This patch also removes a perl idiosyncracy when appending newline
characters to a string. It changes code like "#endif" . "\n" to
"#endif\n".
Tested on Mac OS and Red Hat Linux.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4199 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
was left untouched if the new content was empty. This meant that
empty files were never generated, and existing non-empty files were
never made empty.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4198 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4189 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
only read the file if it its size equals the length of the rdata string.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4181 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the last macro argument is empty, it thinks there is one argument too
few. That is, the following code
#define M2(a,b)
M2(x,)
leads to an error message stating that M2 was used with only a single
argument. This is wrong, as it is called with two arguments, where
the second argument is the empty string. After reading the GNU cpp
manual, I think that the ANSI standard requires that empty arguments
must be handled.
The problem is that the routine SplitArgs that decodes the macro
arguments cannot distinguish between an empty last argument and no
argument, as both are represented by an empty string. I change the
routine so that an empty string always means "empty argument". This
means that SplitArgs cannot be called any more if there are no
arguments -- but this does not matter. I place a corresponding if
statement around the call.
Empty macro arguments may cause problems on some system. A later
patch will produce warnings or errors for them.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4179 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4168 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4167 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4156 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4155 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
token concatenation.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4153 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4152 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
array shapes. They used to have a digit appended to an existing group
name, which can clash with another existing group name. The new name
has the digit in front, which cannot be a legal group name.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4147 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declare and initialise local variables. They also add the necessary
magic to prevent compiler warnings about unused variables.
If the compiler supports __attribute__((unused)), then use this.
Otherwise, use the existing fallback of taking the variable's
address. In Fortran, use the variable's kind as fallback.
Use these macros in autogenerated code and in "cctk.h".
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4146 17b73243-c579-4c4c-a9d2-2d5706c11dac
|