| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
is not needed.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4450 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
which checks for mixed-dimensional GFs.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4339 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GridFuncStuff bug fix and cleanup
http://www.cactuscode.org/old/pipermail/patches/2006-May/000165.html
It fixes two minor bugs (that is, bugs that weren't bugging anybody right
now). It also includes an overall cleanup of the code, which begain with
the first bug fix, and resulted in the discovery of the second bug.
The first bug fix was to put in
use strict;
(According to L. Wall, a Perl file without use strict constitutes a bug.)
This resulted in lots of errors about variables needing their scope to be
specified. So I did this.
At the end, I found that I couldn't fix a certain occurrance of $group.
There was no sensible way that it was being set. The code was to produce
a warning concerning creating groups with mixed dimensions. See
'warn_mixeddim_gfs'.
The Perl code was taking a global value of $group set at build time to be
the last group in a loop. However, the offending group is determined at
run time in CreateThornGroupInitializers. So the warning message would
typically be wrong.
Affect code written in
bindings/Variables/<thorn>.c
Also: Perl 5-ied function calls
deleted great wads of commented-out code
Testing
-------
Ran testsuites on my laptop with Whisky benchmark thornlist.
No change was detected in the results.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4315 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4155 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
array shapes. They used to have a digit appended to an existing group
name, which can clash with another existing group name. The new name
has the digit in front, which cannot be a legal group name.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4147 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declare and initialise local variables. They also add the necessary
magic to prevent compiler warnings about unused variables.
If the compiler supports __attribute__((unused)), then use this.
Otherwise, use the existing fallback of taking the variable's
address. In Fortran, use the variable's kind as fallback.
Use these macros in autogenerated code and in "cctk.h".
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4146 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4140 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4115 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@4074 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3973 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3963 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
compiler warnings about the restrict qualifier.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3952 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3920 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
correct type. This is necessary to call Fortran routines from C++.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3900 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
| |
Patch from Yaakoub.
Fixes PR 1818.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3837 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
This closes Cactus/1663: incorrect interface is undetected by CST but produces runtime error.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3679 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
local variables/parameters are now used in their declarations block
without requiring separate USE_CCTK_* macros).
This closes PR Cactus/1657: CST doesn't ignore braces "{" instring literals.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3677 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3473 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
Allow vector groups with more than one declared variable.
Much of this patch consists of removing special case code for scalars.
Scalars are now almost everywhere treated as rank 0 arrays.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3465 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
Extend routines to handle the new type.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3431 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
| |
CST stage will be identical. This is necessary at least since perl
5.8.1 to avoid redundant recompilation.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3425 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3279 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
doesn't error for DIM 1
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3260 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
Fixes Cactus/1128
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3257 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
parsed properly.
Fixes Cactus/1520.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3222 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
variables from C wrappers to scheduled fortran routines.
Now this feature is only enabled in debugging configurations (DEBUG=yes).
For other configurations, a pointer to a local dummy variable is passed now
as a reference to those variables.
This fixes problems with certain fortran compilers (SGI, Hitachi) which may
generate conditional load/store ops with a certain optimization level.
Such optimizations require fortran data references to be non-NULL.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3142 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3106 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3105 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
in the CST-generated file "Variables/${thorn}.c" where it is also registered.
No "${thorn}_FortranWrapper.c" files are created anymore which should save
some compilation time during a rebuild.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3100 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
Cactus/1365.
Fix spelling of 'arithmetic'.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@3097 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
they call the flesh-internal routine CCTKi_VarDataPtr() now to obtain the
data pointer for a given variable. This replaces a call to CCTK_VarIndex()
which returned an invalid index for non-existing variables and thus was a
potential source for a code crash. Calling CCTKi_VarDataPtr() should also
be faster than CCTK_VarIndex() and makes the macros a bit shorter.
Also cleaned up the other CST generated code a bit, added a grdoc header.
You must also update src/main/Groups.c and lib/sbin/GridFuncStuff.pl now
and do a 'make <configuration>-clean; make <configuration>-rebuild;'.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2912 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DECLARE_CCTK_ARGUMENTS macro. This fixes the problem when the variable didn't
exist (because the providing thorn wasn't activated).
Now the exanded macro is also slightly shorter than the old definition which
makes the preprocessor happy.
You must reconfigure Cactus in order to take this change into effect.
But there's no urgent need for it.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2908 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You can now do
TAGS='foo=... bar=...'
in a group definition in your interface.ccl files.
The intention is that this can be used to assign tensor types and coordinate
systems to gorups.
This is implemented as a table, the handle of which you can get by calling
CCTK_GroupTagsTable
or
CCTK_GroupTagsTableI
and query using the normal table operators.
Note that currently the Util_TableCreateFromString function, which is used to generate
the table, doesn't support setting of string members. This will be changed soon.
Tom
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2845 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
A thorn's own parameters may be unqualified, shared parameters must be
fully qualified.
Tom
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2688 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
will put everything up to the closing bracket for a routine into a new block.
Also, the USE_CCTK macro is now appended directly to the CCTK_DECLARE macro.
There is no need anymore to use CCTK_NO_AUTOUSE_MACRO.
Also changed the way how parameters and arguments are used within the USE_CCTK
macros: now it's done by "(void) (parameter = 0);" which is better than
assigning the address of it to some dummy pointer.
This fixes problems where one had to parse for a possible return statement
at the end of the routine.
This fix closes PR Cactus/949.
Also did some perl code optimization and added grdoc headers for files
generated by the CST.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2676 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2501 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
parameters.
Tom
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2445 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
This allows ADM_BSSN to compile again on irix systems where the CCTK_FARGUMENTS macro couldn't be expanded anymore by the system's preprocessor.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2412 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
Tom
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2407 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
conflicts with user variables. We should really change to passing in as an array
rather than <dim> seperate args.
Tom
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2406 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
| |
integer constants combined with +,-,/ and *, with parentheses for the
sizes of GAs and the length of vector groups.
Tom
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2404 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
defined as
<type> <group_name>[<size>] ...
as per a normal 1 variable group except with an extra argument. This
creates a vector of GVS, with an extra index (the last one for a GA or GF)
corresponding to the element in the vector. For scalars this creates an array
similar to a DISTRIB=CONSTANT GA. <size> may be either an integer or an
integer-valued parameter (which must not be steerable).
So, fortran sees
REAL foo[param] TYPE=GF DIM=3
as
CCTK_REAL foo(nx,ny,nz,param)
and in C it should be accessed as foo[CCTK_GFINDEX3D(cctkGH,i,j,k)*l]
When we have COMPACT groups you will also be able to make the extra index
the first one rather than the last one.
Please treat this as volatile until it is documented, and let me know if you are using
it.
Tom
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2393 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
Now this can be a comma-separated list of positive integer constants or
parameter names (optionally with an integer constant added/substracted
to/from it).
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2328 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
causes for the errors.
At the moment the help message is always shown, since I've only added a couple so far.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2307 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2262 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
| |
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2257 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
| |
'const void *' dummy pointer for assignments.
This should also fix PR Cactus-715.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2227 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
| |
At the moment this is still crude, only check is that the parameter name is
in a thorn, I'm not checking the implementation/thorn name
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2177 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
|
|
| |
is always timelevel 0, and the oldest timelevel is indexed
CCTK_NumTimeLevelsFromVarI(index) - 1
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2164 17b73243-c579-4c4c-a9d2-2d5706c11dac
|
|
|
|
|
|
|
| |
Need to rebuild to implement this.
git-svn-id: http://svn.cactuscode.org/flesh/trunk@2163 17b73243-c579-4c4c-a9d2-2d5706c11dac
|