From c79196b8b1c5eb99a2f240aaf0069853d798bdd0 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Tue, 31 Jul 2018 09:08:48 -0700 Subject: db/manager: Drop async method As far as I can tell using a separate process doesn't actually improve performance, it makes it worse. The work that we're passing off to the separate function isn't necessarily work that's well suited to being handed off, there isn't a lot of computation and the objects that need to be passed across the pipe are fairly large (at least when considering a pipe). Converting the function to a generator gives better performance and simplifies the implementation. --- tests/db/test_manager.py | 1 - 1 file changed, 1 deletion(-) (limited to 'tests') diff --git a/tests/db/test_manager.py b/tests/db/test_manager.py index 0f3a64ac..dbef6c6c 100644 --- a/tests/db/test_manager.py +++ b/tests/db/test_manager.py @@ -71,7 +71,6 @@ class TestDBManager(utilities.TestCaseClassCleanup): cls.manager = manager.DBManager(cls.dbpath) # clean up temporary database - cls.addClassCleanup(cls.manager.kill_search_processes) cls.addClassCleanup(shutil.rmtree, cls.dbpath) # let global settings manager read our temporary notmuch config -- cgit v1.2.3