From eaeda2b8773d112c7e858d7ce29d3510bacbd484 Mon Sep 17 00:00:00 2001 From: Lucas Hoffmann Date: Tue, 9 Jan 2018 00:03:08 +0100 Subject: Use any() instead of a for loop with a break statement --- tests/settings/manager_test.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/settings/manager_test.py b/tests/settings/manager_test.py index e5d26b9e..dc5182d3 100644 --- a/tests/settings/manager_test.py +++ b/tests/settings/manager_test.py @@ -102,12 +102,8 @@ class TestSettingsManager(unittest.TestCase): with mock.patch('alot.settings.utils.logging') as mock_logger: SettingsManager(alot_rc=f.name) - success = False - for call_args in mock_logger.info.call_args_list: - msg = call_args[0][0] - if all([s in msg for s in unknown_settings]): - success = True - break + success = any(all([s in call_args[0][0] for s in unknown_settings]) + for call_args in mock_logger.info.call_args_list) self.assertTrue(success, msg='Could not find all unknown settings in ' 'logging.info.\nUnknown settings:\n{}\nCalls to mocked' ' logging.info:\n{}'.format( -- cgit v1.2.3