From 145489a5434aa825077ae8570afe748722d055e2 Mon Sep 17 00:00:00 2001 From: Anton Khirnov Date: Thu, 2 Jan 2020 18:23:29 +0100 Subject: widgets/thread: drop thread_focus_linewise There is no meaningful reason to focus on individual lines, since they are unactionable. --- alot/defaults/alot.rc.spec | 5 ----- alot/widgets/thread.py | 10 +--------- docs/source/configuration/alotrc_table | 12 ------------ 3 files changed, 1 insertion(+), 26 deletions(-) diff --git a/alot/defaults/alot.rc.spec b/alot/defaults/alot.rc.spec index 4a8999b3..0f70e949 100644 --- a/alot/defaults/alot.rc.spec +++ b/alot/defaults/alot.rc.spec @@ -276,11 +276,6 @@ history_size = integer(default=50) # The number of seconds to wait between calls to the loop_hook periodic_hook_frequency = integer(default=300) -# Split message body linewise and allows to (move) the focus to each individual -# line. Setting this to False will result in one potentially big text widget -# for the whole message body. -thread_focus_linewise = boolean(default=True) - # Key bindings [bindings] diff --git a/alot/widgets/thread.py b/alot/widgets/thread.py index f013bded..61799aa3 100644 --- a/alot/widgets/thread.py +++ b/alot/widgets/thread.py @@ -96,15 +96,7 @@ class TextlinesList(SimpleTree): :class:`SimpleTree` that contains a list of all-level-0 Text widgets for each line in content. """ - structure = [] - - # depending on this config setting, we either add individual lines - # or the complete context as focusable objects. - if settings.get('thread_focus_linewise'): - for line in content.splitlines(): - structure.append((FocusableText(line, attr, attr_focus), None)) - else: - structure.append((FocusableText(content, attr, attr_focus), None)) + structure = [(FocusableText(content, attr, attr_focus), None)] SimpleTree.__init__(self, structure) diff --git a/docs/source/configuration/alotrc_table b/docs/source/configuration/alotrc_table index 12020398..c2a04618 100644 --- a/docs/source/configuration/alotrc_table +++ b/docs/source/configuration/alotrc_table @@ -668,18 +668,6 @@ :default: True -.. _thread-focus-linewise: - -.. describe:: thread_focus_linewise - - Split message body linewise and allows to (move) the focus to each individual - line. Setting this to False will result in one potentially big text widget - for the whole message body. - - :type: boolean - :default: True - - .. _thread-indent-replies: .. describe:: thread_indent_replies -- cgit v1.2.3